Switch GitHub CI to dtolnay/rust-toolchain #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. The fact that #241 now doesn't fail is completely obscure though... |
aldanor
approved these changes
Jun 10, 2023
|
Let me know if it's good to merge, I'll merge it then 👍 |
|
Maybe wait for #229 which adds another CI job? |
|
Just squash-merged #229, so this one can now be rebased I guess |
mulimoen
force-pushed
the
feature/update-ci
branch
from
0e904f4 to
d1864c7
Compare
|
And... wine doesn't fail again. Completely obscure. Is it ok to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces actions-rs/toolchain with dtolnay/rust-toolchain since the former is showing deprecation warnings and is unmaintained.
Fixes #241 (no idea why this is suddenly working again)