Maintenance updates #268
Merged
Maintenance updates #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldanor
force-pushed
the
feature/2024-jan-maintenance
branch
from
5b3f92c to
90d96e2
Compare
mulimoen
approved these changes
Jan 30, 2024
There was a problem hiding this comment.
Going to rubber stamp this, would be great to have a new version of these crates out.
I think the wine failure is due to hdf5 built as dev does not build from source with the new resolver version. One could --exclude hdf5-derive for this step, and add another step with cargo test --features hdf5-derive --feature hdf5/static. Update: This fixed compilation, unfortunately running the compile time tests requires some additional magic. I think we can disable this test for wine, as we do for other jobs in CI
The mingw failure I have not been able to replicate locally
mulimoen
force-pushed
the
feature/2024-jan-maintenance
branch
from
f40ac47 to
214dabd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some long overdue maintenance updates.
(We should prob release a version soon, are we still stuck with the 1.14 problem?..)