Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cs fixer 8 4 #166

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Cs fixer 8 4 #166

merged 2 commits into from
Nov 22, 2024

Conversation

aldas
Copy link
Owner

@aldas aldas commented Nov 22, 2024

With 8.4 PHPStan complains about https://wiki.php.net/rfc/deprecate-implicitly-nullable-types this PR fixes these

Fixer is run with

sudo docker run -it --rm -v $(pwd):/code ghcr.io/php-cs-fixer/php-cs-fixer:${FIXER_VERSION:-3-php8.3} fix --rules nullable_type_declaration_for_default_null_value src

PHPStan can be run with

sudo docker run -it --rm -v .:/code  php:8.4.1-zts-bookworm /bin/sh -c cd /code && vendor/bin/phpstan analyse --no-progres

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 98.93617% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.97%. Comparing base (b18323b) to head (2960eb4).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Utils/Charset.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #166   +/-   ##
=========================================
  Coverage     98.96%   98.97%           
  Complexity      936      936           
=========================================
  Files            73       73           
  Lines          2426     2429    +3     
=========================================
+ Hits           2401     2404    +3     
  Misses           25       25           
Flag Coverage Δ
unittests 98.97% <98.93%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@aldas aldas merged commit 49b7453 into master Nov 22, 2024
4 checks passed
@aldas aldas deleted the cs_fixer_8-4 branch November 22, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants