Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
docs(RELEASE_MANAGEMENT): explain auto-merge for release PRs is a no-no
The detailed explanation is here: Do not enable auto-merging on GitHub for the pull request doing the release. The problem with auto-merging here is that it would modify the release commit's SHA as the rebase would happen on GitHub's servers where your git signing identity is not available to use given that GitHub does (should) not have access to your private key for signing. The way the preserve your commit signature as valid the commit SHA must remain the same and the way to achieve this is to perform the pull request merging with fast forward. The merging ensures that there is no commit SHA change and the `--ff-only` option ensures that there is no merge commit to throw a wrench in the process. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
- Loading branch information
fa6cb10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold
0.05
.plugin-ledger-connector-besu_HTTP_GET_getOpenApiSpecV1
761
ops/sec (±2.95%
)745
ops/sec (±2.79%
)0.98
This comment was automatically generated by workflow using github-action-benchmark.
CC: @petermetz