Skip to content

Conversation

@imyuanx
Copy link
Contributor

@imyuanx imyuanx commented Jan 26, 2022

I not have bookmarks-core so I can't test and i don't know if it's normal.

@alefragnani
Copy link
Owner

Hi @yunying1 ,

First of all, thank you for your PR.

As discussed in #509, please open an issue about the feature you are proposing, so we can gather feedback from other users.

Thank you

@alefragnani
Copy link
Owner

Hi @yunying1 ,

You don't need to close the PR. Simply open the issue, and let's open the discussion. If there is no change in the core repo, we could use the PR as the full solution.

Just change it to a Draft PR

Thank you

@imyuanx
Copy link
Contributor Author

imyuanx commented Feb 8, 2022

Hi @yunying1 ,

You don't need to close the PR. Simply open the issue, and let's open the discussion. If there is no change in the core repo, we could use the PR as the full solution.

Just change it to a Draft PR

Thank you

Thank you for your tolerance for novices!

@alefragnani alefragnani linked an issue Feb 8, 2022 that may be closed by this pull request
Copy link
Owner

@alefragnani alefragnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

First of all, sorry for the late reply. I know it's been a long time, and I totally understand if you don't have more interest in the PR. But, if you do, I would you ask to update/sync your fork and apply the change I reviewed. On the other hand, if you don't have interest anymore, don't worry, I can create another PR and use your as reference, to add this feature in the next release.

Thanks for your understanding

@alefragnani alefragnani added PR needs update The PR needs review by the author and removed need more info labels Jan 10, 2026
@imyuanx
Copy link
Contributor Author

imyuanx commented Jan 16, 2026

I'm still using vscode-bookmarks and need this feature. I'll sync the fork and apply the changes as soon as possible. Thanks!

@imyuanx imyuanx requested a review from alefragnani January 24, 2026 06:07
@alefragnani alefragnani merged commit 38eefec into alefragnani:master Jan 30, 2026
3 checks passed
@alefragnani alefragnani added PR tested and removed PR needs update The PR needs review by the author labels Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] - Add Clear from All Files command in the Side Bar

2 participants