-
-
Notifications
You must be signed in to change notification settings - Fork 196
Add Clear from All Files command in the Side Bar #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @yunying1 , You don't need to close the PR. Simply open the issue, and let's open the discussion. If there is no change in the core repo, we could use the PR as the full solution. Just change it to a Draft PR Thank you |
Thank you for your tolerance for novices! |
alefragnani
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
First of all, sorry for the late reply. I know it's been a long time, and I totally understand if you don't have more interest in the PR. But, if you do, I would you ask to update/sync your fork and apply the change I reviewed. On the other hand, if you don't have interest anymore, don't worry, I can create another PR and use your as reference, to add this feature in the next release.
Thanks for your understanding
|
I'm still using vscode-bookmarks and need this feature. I'll sync the fork and apply the changes as soon as possible. Thanks! |
…lization keys for new command title
I not have bookmarks-core so I can't test and i don't know if it's normal.