fix: fixed style, run static analysis on push

.github/workflows/cscheck.yml

@@ -1,6 +1,7 @@
 name: Check CS
 
 on:
+    push:
     pull_request_target:
 
 jobs:

.github/workflows/phpstan.yml

@@ -1,6 +1,7 @@
 name: PHPStan
 
 on:
+    push:
     pull_request_target:
 
 jobs:

data/Psr4WithClassMap/Map/ErrorStub.php

@@ -1,5 +1,7 @@
 <?php declare(strict_types=1);
 
-class Error
-{
+if (!class_exists(Error::class, false)) {
+    class Error
+    {
+    }
 }

lib/FilterIterator/PhpDocumentor/InterfaceImplementationFilterIterator.php

@@ -36,7 +36,7 @@ public function __construct(Iterator $iterator, private readonly array $interfac
         parent::__construct($iterator);
 
         $this->getMetadata = method_exists(Class_::class, 'getMetadata') ?
-            static fn (object $reflector) => $reflector->getMetadata() :
+            static fn (object $reflector) => $reflector->getMetadata() : /** @phpstan-ignore-line */
             static fn (object $reflector) => MetadataRegistry::getInstance()->getMetadata($reflector);
     }
 

lib/FilterIterator/PhpDocumentor/SuperClassFilterIterator.php

@@ -32,7 +32,7 @@ public function __construct(Iterator $iterator, private readonly string $superCl
         parent::__construct($iterator);
 
         $this->getMetadata = method_exists(Class_::class, 'getMetadata') ?
-            static fn (object $reflector) => $reflector->getMetadata() :
+            static fn (object $reflector) => $reflector->getMetadata() : /** @phpstan-ignore-line */
             static fn (object $reflector) => MetadataRegistry::getInstance()->getMetadata($reflector);
     }
 

lib/Finder/FinderInterface.php

@@ -85,6 +85,8 @@ public function notInNamespace(string|array $namespaces): static;
      * Sets a custom callback for class filtering.
      * The callback will receive the class name as the only argument.
      *
+     * @param callable(object, string):bool|null $callback
+     *
      * @return $this
      */
     public function filter(callable|null $callback): static;
@@ -125,6 +127,8 @@ public function notPath(string $pattern): static;
      * Sets a custom callback for file filtering.
      * The callback will receive the full filepath as the only argument.
      *
+     * @param callable(string):bool|null $callback
+     *
      * @return $this
      */
     public function pathFilter(callable|null $callback): static;

lib/Finder/FinderTrait.php

@@ -50,10 +50,10 @@ trait FinderTrait
     /** @var string[] */
     private array|null $notPaths = null;
 
-    /** @var callable|null */
+    /** @var callable(object, string):bool|null */
     private $filterCallback = null;
 
-    /** @var callable|null */
+    /** @var callable(string):bool|null */
     private $pathFilterCallback = null;
 
     private bool $skipNonInstantiable = false;

lib/Iterator/PhpDocumentorIterator.php

@@ -13,7 +13,7 @@
 use phpDocumentor\Reflection\DocBlockFactoryInterface;
 use phpDocumentor\Reflection\File\LocalFile;
 use phpDocumentor\Reflection\Fqsen;
-use PhpDocumentor\Reflection\Metadata\Metadata as PhpDocMetadata;
+use phpDocumentor\Reflection\Metadata\Metadata as PhpDocMetadata;
 use phpDocumentor\Reflection\Php\Class_;
 use phpDocumentor\Reflection\Php\Enum_;
 use phpDocumentor\Reflection\Php\Factory;
@@ -31,6 +31,7 @@
 use function array_values;
 use function assert;
 use function class_exists;
+use function is_string;
 use function ltrim;
 use function method_exists;
 use function Safe\preg_match;
@@ -128,6 +129,7 @@ protected function getGenerator(): Generator
             };
         } else {
             $addMetadata = static function (object $target, PhpDocMetadata $metadata): void {
+                assert(method_exists($target, 'addMetadata'));
                 $target->addMetadata($metadata);
             };
         }
@@ -150,7 +152,7 @@ protected function getGenerator(): Generator
                     $factory->create($contextStack, new LocalFile($path), $this->strategies);
                     $reflector = $project->getFiles()[$path];
                 }
-            } catch (Throwable) {
+            } catch (Throwable) { /** @phpstan-ignore-line */
                 continue;
             }
 
@@ -173,6 +175,8 @@ static function (object $class) use (&$symbols): object {
         }
 
         foreach ($files as $path => $fileSymbols) {
+            assert(is_string($path));
+
             foreach ($fileSymbols as $fileSymbol) {
                 if ($fileSymbol instanceof Class_) {
                     $parents = [];

lib/Iterator/PhpParserIterator.php

@@ -24,6 +24,7 @@
 use function assert;
 use function class_exists;
 use function file_get_contents;
+use function is_string;
 use function ltrim;
 use function Safe\preg_match;
 
@@ -111,6 +112,8 @@ static function (Stmt\ClassLike $class) use (&$symbols): object {
         }
 
         foreach ($files as $path => $fileSymbols) {
+            assert(is_string($path));
+
             foreach ($fileSymbols as $fileSymbol) {
                 if ($fileSymbol instanceof Stmt\Class_) {
                     $parents = [];

lib/Util/BogonFilesFilter.php

@@ -14,6 +14,7 @@ final class BogonFilesFilter
         // https://github.com/alekitto/class-finder/issues/13#issuecomment-2010509501
         '(?:' .
             '(?:symfony/(?:cache|symfony/Component/Cache)/Traits/(?:Redis(?:Cluster)?\dProxy|ValueWrapper)|' .
+            'symfony/polyfill-[^/]+/Resources/stubs/(?:Attribute|Normalizer)|' .
             'php-coveralls/php-coveralls/src/Bundle/CoverallsBundle/Console/Application|' .
             'dealerdirect/phpcodesniffer-composer-installer/src/Plugin|' .
             'myclabs/php-enum/src/PHPUnit/Comparator|' .
@@ -22,9 +23,14 @@ final class BogonFilesFilter
         ')\.php$)' .
     '#x';
 
+    /**
+     * @param Closure(string):bool|null $filter
+     *
+     * @return Closure(string):bool
+     */
     public static function getFileFilterFn(Closure|null $filter = null): Closure
     {
-        $filter ??= static fn () => true;
+        $filter ??= static fn (string $unused) => true;
 
         return static function (string $path) use ($filter): bool {
             if (preg_match(self::BOGON_FILES_REGEX, $path) === 1) {

lib/Util/PhpDocumentor/MetadataRegistry.php

@@ -4,7 +4,7 @@
 
 namespace Kcs\ClassFinder\Util\PhpDocumentor;
 
-use PhpDocumentor\Reflection\Metadata\Metadata;
+use phpDocumentor\Reflection\Metadata\Metadata;
 use WeakMap;
 
 final class MetadataRegistry

phpdoc-compat-metadata.php

@@ -2,7 +2,7 @@
 
 declare(strict_types=1);
 
-namespace PhpDocumentor\Reflection\Metadata;
+namespace phpDocumentor\Reflection\Metadata;
 
 use function interface_exists;
 

tests/unit/Finder/ComposerFinderTest.php

@@ -249,6 +249,7 @@ public function testFinderShouldFilterByNotPathRegex(): void
         ], iterator_to_array($finder));
     }
 
+    /** @runInSeparateProcess */
     public function testFinderShouldFilterByPathCallback(): void
     {
         $finder = (new ComposerFinder())->useAutoloading(false);
@@ -271,4 +272,12 @@ public function testFinderShouldFilterByPathCallback(): void
             Psr4\Foobarbar::class => new ReflectionClass(Psr4\Foobarbar::class),
         ], iterator_to_array($finder));
     }
+
+    /** @runInSeparateProcess */
+    public function testBogonFilesFilter(): void
+    {
+        $finder = (new ComposerFinder())->skipBogonFiles();
+
+        self::assertNotEmpty(iterator_to_array($finder));
+    }
 }