Open
Conversation
| "babel": "babel src --out-dir dist --copy-files", | ||
| "babel:watch": "babel -w src --out-dir dist", | ||
| "nodemon": "nodemon ./dist/index.js", | ||
| "start": "start npm run babel:watch && start npm run nodemon" |
There was a problem hiding this comment.
Adds db:drop, db:create, db:migrate, db.seed:all into one npm's script, please
Why db:drop?
It would be better to make sure that database doesn't exist because in other way it gives to us error message that database is already exist.
|
|
||
| app.use(queryParser()); | ||
| app.use(cookieParser(), setCoockies()); | ||
| app.use(bodyParser.urlencoded({ extended: true })); |
There was a problem hiding this comment.
There is from Express v4 bodyParser libraty doesn't need because the one already is situated in Express library.
app.use(express.urlencode({ extenred: true }));
app.use(express.json());
| } else { | ||
| products.push(newProduct); | ||
| res.status(201).send(products); | ||
| Product.create(newProduct) |
There was a problem hiding this comment.
Adds check if product already exist in db, please
Hits: findAndCreate
| var Sequelize = require('sequelize'); | ||
| var basename = path.basename(__filename); | ||
| var env = process.env.NODE_ENV || 'development'; | ||
| var config = require(`${__dirname}/../config/config.json`)[env]; |
| "dialect": "postgres" | ||
| }, | ||
| "test": { | ||
| "username": "local-postgress-1.0", |
| "dialect": "postgres" | ||
| }, | ||
| "production": { | ||
| "username": "local-postgress-1.0", |
| if (allowAccess) { | ||
| const token = jwt.sign({ userName }, 'secret13', { expiresIn: 30 }); | ||
| if (allowAccess) { | ||
| const token = jwt.sign({ userName }, 'secret13', { expiresIn: 10000 }); |
There was a problem hiding this comment.
Export expiresIn into config and env variable, please
|
Take a look in advance topic, please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.