Open
Conversation
aleksandra-sturova
force-pushed
the
task_09
branch
2 times, most recently
from
f5ba677 to
c9eec8e
Compare
aleksandra-sturova
force-pushed
the
task_09
branch
from
c9eec8e to
79f35e4
Compare
spitaI
reviewed
Dec 15, 2020
| @@ -0,0 +1,2 @@ | |||
| product=https://y8cv6h0sql.execute-api.eu-west-1.amazonaws.com/dev/products | |||
There was a problem hiding this comment.
Hi! Just an advice: .env files should be added to .gitignore, if not - you can expose your secret data :)
spitaI
approved these changes
Dec 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task 9
502 http://aleksandra-sturova-bff-service-dev.eu-west-1.elasticbeanstalk.com/
Products http://aleksandra-sturova-bff-service-dev.eu-west-1.elasticbeanstalk.com/product
Products POST
Product by id (also screen with invalid id below) http://aleksandra-sturova-bff-service-dev.eu-west-1.elasticbeanstalk.com/product/c01cf184-961b-4de7-8aec-ace10c7469f4
Cart http://aleksandra-sturova-bff-service-dev.eu-west-1.elasticbeanstalk.com/cart
All product-service and CART services methods should work correctly if requested via bff-service
3 - A working and correct express application should be in the bff-service folder. Reviewer can start this application locally with any valid configuration in the .env file and this application should works as described in the task 9.1 ✅
5 - The bff-service should be deployed with Elastic Beanstalk. The bff-service call should be redirected to the appropriate service : product-service or CART. The response from the bff-service should be the same as if product-service or CART services were called directly. ✅