Skip to content

Fix sentry #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 19, 2024
Merged

Fix sentry #973

merged 5 commits into from
Nov 19, 2024

Conversation

nop33
Copy link
Member

@nop33 nop33 commented Nov 18, 2024

@nop33 nop33 requested a review from mvaivre November 18, 2024 18:32
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b64e053

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nop33 nop33 added the 📱 MW Mobile wallet label Nov 18, 2024
mvaivre
mvaivre approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@mvaivre mvaivre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

apps/mobile-wallet/setupErrorHandling.ts
Comment on lines +29 to +30
if (event.contexts?.device?.model?.includes('iPad Pro') && event.contexts?.device?.model_id?.includes('Mac')) {
return null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nop33 nop33 merged commit 2ec9c6f into next Nov 19, 2024
5 checks passed
@nop33 nop33 deleted the fix-sentry branch March 4, 2025 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaivre mvaivre mvaivre approved these changes

Assignees
No one assigned
Labels
📱 MW Mobile wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nop33 @mvaivre