Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Master #52

Merged
merged 67 commits into from
Feb 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
67 commits
Select commit Hold shift + click to select a range
04f7b04
Changed conditions of running GitHub actions (#2082)
george-gca Jan 19, 2024
6700000
Downgrade ruby version (#2098)
george-gca Jan 19, 2024
7c617d8
Update INSTALL.md (#2091)
pourmand1376 Jan 19, 2024
711af76
Fixed dark mode not working after purgecss
george-gca Jan 20, 2024
30f7ab0
Added one more researcher using al-folio (#2105)
JonaRuthardt Jan 21, 2024
65c5c8a
Added acknowledge section to feature_request.md
george-gca Jan 22, 2024
3927200
Added diff tools to INSTALL.md
george-gca Jan 22, 2024
8af6b73
Prettier check now generates a diff comment on PR (#2085)
george-gca Jan 22, 2024
7ed8f49
Update prettier-on-pr.yml permissions
george-gca Jan 22, 2024
27d2fa0
Changed how prettier comments on PR works (#2112)
george-gca Jan 22, 2024
bbaae0a
Fixed prettier actions (#2113)
george-gca Jan 22, 2024
db0a92b
Moved prettier comment on PR to its own action (#2114)
george-gca Jan 22, 2024
b83a0e3
Added Lighthouse test GitHub action (#2084)
george-gca Jan 23, 2024
0510031
Lighthouse-Badger[bot]: Results Added
github-actions[bot] Jan 23, 2024
25eac65
Fixed lighthouse html viewer links
george-gca Jan 23, 2024
10507a8
Added anchor to category sections (#2006)
fabawi Jan 23, 2024
8dd678c
Added lighthouse_results to .prettierignore
george-gca Jan 23, 2024
ec9571a
Improved issues templates (#2110)
george-gca Jan 23, 2024
b0b19a1
Removed 0 from bug report
george-gca Jan 23, 2024
2fa8141
Updated links in 1_bug_report.yml
george-gca Jan 23, 2024
6fcc283
Updated links in 2_feature_request.yml
george-gca Jan 23, 2024
fc23860
Updated links in issue template config.yml
george-gca Jan 23, 2024
7d861cb
Fixed url in config.yml
george-gca Jan 23, 2024
c99a453
Fixed urls in 2_feature_request.yml
george-gca Jan 23, 2024
0c08237
Fixed urls in 1_bug_report.yml
george-gca Jan 23, 2024
7638547
Updated checkout step in lighthouse-badger.yml
george-gca Jan 23, 2024
1d84621
Lighthouse-Badger[bot]: Results Added
github-actions[bot] Jan 23, 2024
a7d6b37
Added support for Chart.js (#2126)
george-gca Jan 26, 2024
3ec0ff4
Added integrity check to mermaid.js
george-gca Jan 27, 2024
4f6fe1a
Added Echarts support (#2129)
george-gca Jan 27, 2024
1492cb9
GeoJSON support (#2130)
george-gca Jan 27, 2024
f6bb6b5
Vega lite support (#2131)
george-gca Jan 27, 2024
53fb011
Added leaflet reference to 2024-01-26-geojson-map.md
george-gca Jan 27, 2024
f69d99a
Closing #2122 (#2135)
george-gca Jan 28, 2024
2492ab3
Workflow fix (#2136)
george-gca Jan 28, 2024
8e93db5
Advanced image viewers (#2132)
george-gca Jan 28, 2024
ef84782
Support for diff2html (#2133)
george-gca Jan 28, 2024
06bc367
Move libs versions to config (#2139)
george-gca Jan 28, 2024
43a3dd9
Update FAQ.md with Prettier info
george-gca Jan 28, 2024
1935a2a
Avoid deploying site when changes are in README files
george-gca Jan 28, 2024
3c80fdb
Lighthouse-Badger[bot]: Results Added
github-actions[bot] Jan 28, 2024
2356aea
Removing lighthouse results from deploy trigger
george-gca Jan 28, 2024
5337984
Removing lighthouse_results from broken-links trigger
george-gca Jan 28, 2024
f3d3efa
Lighthouse-Badger[bot]: Results Added
github-actions[bot] Jan 28, 2024
fa5b411
Adding display swap to Google Fonts
george-gca Jan 28, 2024
e977319
Added link to jekyll docs about post file naming
george-gca Jan 29, 2024
18f7307
Fixed axe workflow (#2149)
george-gca Jan 30, 2024
ae0c1a6
improved redirect mapping (#2157)
asboyer Feb 4, 2024
c39df67
Updated FAQ with old repository information (#2161)
george-gca Feb 5, 2024
4cf657e
Added jekyll-diagrams error to FAQ (#2162)
george-gca Feb 5, 2024
1ce5865
center footer text by default (#2165)
eolesinski Feb 6, 2024
7c2e1c2
Fix Image Dimension Styles for Better Responsiveness (#2166)
ZL-Asica Feb 7, 2024
ef647a6
Update README.md (#2182)
ZL-Asica Feb 11, 2024
007b504
Update README.md (#2187)
Stavros Feb 11, 2024
a0bcaaf
Added support for google scholar citations (#2193)
george-gca Feb 13, 2024
b4e4232
Fixed bug when number has , on scholar citations
george-gca Feb 13, 2024
9794c62
Add academic community example (#2195)
slymane Feb 13, 2024
0f0feb1
Fixed related publications appearing in toc (#2196)
george-gca Feb 13, 2024
26fad31
remove the space in names of "site" (#2188)
furkanakkurt1335 Feb 14, 2024
2a056fe
Implement Default Lazy Loading for Images with Configurable Option (#…
ZL-Asica Feb 14, 2024
40b22ff
fix author spacing (#2197)
eolesinski Feb 14, 2024
f067edc
Changed lazy loading in figure.liquid
george-gca Feb 14, 2024
5df7a6a
Changed lazy loading in _config.yml
george-gca Feb 14, 2024
0b84a12
Added/Improved Formatting for Checkboxes (#2191)
DavidKrassnig Feb 14, 2024
b316653
Lighthouse-Badger[bot]: Results Added
github-actions[bot] Feb 14, 2024
6e215a1
Lighthouse fixes (#2199)
george-gca Feb 14, 2024
e430a89
Lighthouse-Badger[bot]: Results Added
github-actions[bot] Feb 14, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 101 additions & 0 deletions .github/ISSUE_TEMPLATE/1_bug_report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,101 @@
name: 🐛 Report a bug
description: Any errors.
labels: ["needs triage", "bug"]
body:
- type: markdown
attributes:
value: >
Before you go any further. Is this really a **🐛 bug**?

If it's a question about how al-folio works, have a look at our [documentation](https://github.com/alshedivat/al-folio/blob/master/README.md),
[frequently asked questions](https://github.com/alshedivat/al-folio/blob/master/FAQ.md),
[past questions](https://github.com/alshedivat/al-folio/discussions/categories/q-a),
or [ask a question](https://github.com/alshedivat/al-folio/discussions/new?category=q-a).

- type: checkboxes
id: requirements
attributes:
label: Have you checked that your issue isn't already filed?
description: >
Please check if somebody else has already filed the same issue.
If you find a similar issue, please add a 👍 reaction or comment on the original post.
options:
- label: I read through [FAQ](https://github.com/alshedivat/al-folio/blob/master/FAQ.md) and searched through the [past issues](https://github.com/alshedivat/al-folio/issues), none of which addressed my issue.
required: true
- label: Yes, I have checked that this issue isn't already filed.
required: true

- type: input
attributes:
label: Bug description
description: A description of the 🐛 bug.
placeholder: A clear and concise description of what the bug is.
validations:
required: true

- type: textarea
attributes:
label: How to reproduce the bug
description: Provide steps to reproduce the 🐛 bug.
placeholder: |
Include steps to reproduce, the expected behaviour, and the actual behaviour.

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
validations:
required: true

- type: textarea
attributes:
label: Error messages and logs
description: >
Provide any error messages and/or logs
placeholder: "Copy the complete error messages and logs"
value: |
```
The error message you got, with the full traceback if available. Please paste it between these triple backticks.
```
validations:
required: false

- type: dropdown
id: os
attributes:
label: What operating system are you using?
description: select all OSs where you have experienced this issue
multiple: true
options:
- Linux
- Mac
- Windows
- Not applicable (e.g. you're using GitHub Pages or other hosting)
validations:
required: true

- type: dropdown
id: environment
attributes:
label: Where are you seeing the problem on?
description: select all environments where you have experienced this issue
multiple: true
options:
- "Running locally with Docker"
- "Running locally without Docker"
- "Deployed site"
validations:
required: true

- type: textarea
attributes:
label: More info
description: Add any other info about the issue here.
placeholder: |
Add any other context about the problem here, such as versions of the libraries if running without docker, screenshots, links to the deployed site, etc.
validations:
required: false

- type: markdown
attributes:
value: "**Happy coding!**"
56 changes: 56 additions & 0 deletions .github/ISSUE_TEMPLATE/2_feature_request.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
name: 🚀 Feature request
description: Propose a feature for this project
labels: ["needs triage", "enhancement"]
body:
- type: markdown
attributes:
value: >
Before you go any further, are you sure that this feature is not already implemented?

If it's a question about how al-folio works, have a look at our [documentation](https://github.com/alshedivat/al-folio/blob/master/README.md),
[frequently asked questions](https://github.com/alshedivat/al-folio/blob/master/FAQ.md),
[past questions](https://github.com/alshedivat/al-folio/discussions/categories/q-a),
or [ask a question](https://github.com/alshedivat/al-folio/discussions/new?category=q-a).

- type: checkboxes
id: requirements
attributes:
label: Have you checked that your feature request isn't already filed?
description: >
Please check if somebody else has already filed the same 🚀 feature request.
If you find a similar feature request, please add a 👍 reaction or comment on the original post.
options:
- label: I read through [FAQ](https://github.com/alshedivat/al-folio/blob/master/FAQ.md) and searched through the [past issues](https://github.com/alshedivat/al-folio/issues), none of which addressed my feature request.
required: true
- label: Yes, I have checked that this feature request isn't already filed.
required: true

- type: textarea
attributes:
label: Description & Motivation
description: A clear and concise description of the 🚀 feature proposal
placeholder: |
Please outline the motivation for the proposal.
Is your feature request related to a problem? e.g., I'm always frustrated when [...].
If this is related to another GitHub issue, please link it here

- type: textarea
attributes:
label: Pitch
description: A clear and concise description of what you want to happen.
validations:
required: false

- type: textarea
attributes:
label: Alternatives
description: A clear and concise description of any alternative solutions or features you've considered, if any.
validations:
required: false

- type: textarea
attributes:
label: Additional context
description: Add any other context or screenshots about the feature request here.
validations:
required: false
40 changes: 0 additions & 40 deletions .github/ISSUE_TEMPLATE/bug_report.md

This file was deleted.

8 changes: 8 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
blank_issues_enabled: false
contact_links:
- name: ❓ Ask a Question
url: https://github.com/alshedivat/al-folio/discussions/categories/q-a
about: Ask and answer al-folio related questions.
- name: 📖 Read the documentation
url: https://github.com/alshedivat/al-folio/blob/master/README.md
about: Please consult the documentation before opening any issues!
19 changes: 0 additions & 19 deletions .github/ISSUE_TEMPLATE/feature_request.md

This file was deleted.

28 changes: 20 additions & 8 deletions .github/workflows/axe.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ on:
description: "URL to be checked (e.g.: blog/)"
required: false

permissions:
contents: write

env:
URL: ""

Expand All @@ -28,14 +25,14 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout 🛎️
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.2.2"
bundler-cache: true
- name: Update _config.yml ⚙️
uses: fjogeleit/yaml-update-action@v0.13.1
uses: fjogeleit/yaml-update-action@main
with:
commitChange: false
valueFile: "_config.yml"
Expand All @@ -47,15 +44,30 @@ jobs:
- name: Install and Build 🔧
run: |
pip3 install --upgrade jupyter
npm install -g mermaid.cli
npm install -g purgecss
export JEKYLL_ENV=production
bundle exec jekyll build --lsi
- name: Purge unused CSS 🧹
run: |
npm install -g purgecss
purgecss -c purgecss.config.js
- name: Get Chromium version 🌐
# https://github.com/GoogleChromeLabs/chrome-for-testing?tab=readme-ov-file#other-api-endpoints
run: |
CHROMIUM_VERSION=$(wget -qO- https://googlechromelabs.github.io/chrome-for-testing/LATEST_RELEASE_STABLE | cut -d. -f1)
echo "Chromium version: $CHROMIUM_VERSION"
echo "CHROMIUM_VERSION=$CHROMIUM_VERSION" >> $GITHUB_ENV
- name: Setup Chrome 🌐
id: setup-chrome
uses: browser-actions/setup-chrome@v1
with:
chrome-version: ${{ env.CHROMIUM_VERSION }}
- name: Install chromedriver 🚗
run: |
npm install -g chromedriver@$CHROMIUM_VERSION
- name: Run axe 🪓
# https://github.com/dequelabs/axe-core-npm/tree/develop/packages/cli
run: |
npm install -g @axe-core/cli
npm install -g http-server
http-server _site/ &
axe http://localhost:8080/${{ github.event.inputs.url || env.URL }} --load-delay=1500 --exit
axe --chromedriver-path $(npm root -g)/chromedriver/bin/chromedriver http://localhost:8080/${{ github.event.inputs.url || env.URL }} --load-delay=1500 --exit
28 changes: 11 additions & 17 deletions .github/workflows/broken-links-site.yml
Original file line number Diff line number Diff line change
@@ -1,33 +1,26 @@
name: Check for broken links on site

on:
push:
branches:
- master
- main
pull_request:
branches:
- master
- main
workflow_dispatch:

permissions:
contents: write
workflow_run:
workflows: [Deploy site]
types: [completed]

jobs:
deploy:
check-links-on-site:
# https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#running-a-workflow-based-on-the-conclusion-of-another-workflow
if: ${{ github.event.workflow_run.conclusion == 'success' }}
# available images: https://github.com/actions/runner-images#available-images
runs-on: ubuntu-latest
steps:
- name: Checkout 🛎️
uses: actions/checkout@v3
uses: actions/checkout@v4
- name: Setup Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: "3.2.2"
bundler-cache: true
- name: Update _config.yml ⚙️
uses: fjogeleit/yaml-update-action@v0.13.1
uses: fjogeleit/yaml-update-action@main
with:
commitChange: false
valueFile: "_config.yml"
Expand All @@ -39,10 +32,11 @@ jobs:
- name: Install and Build 🔧
run: |
pip3 install --upgrade jupyter
npm install -g mermaid.cli
npm install -g purgecss
export JEKYLL_ENV=production
bundle exec jekyll build --lsi
- name: Purge unused CSS 🧹
run: |
npm install -g purgecss
purgecss -c purgecss.config.js
- name: Link Checker 🔗
uses: lycheeverse/lychee-action@v1.9.0
Expand Down
36 changes: 35 additions & 1 deletion .github/workflows/broken-links.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,47 @@ name: Check for broken links

on:
push:
branches:
- master
- main
paths:
- "assets/**"
- "**.html"
- "**.js"
- "**.liquid"
- "**/*.md"
- "**.yml"
- "!.github/workflows/axe.yml"
- "!.github/workflows/deploy-docker-tag.yml"
- "!.github/workflows/deploy-image.yml"
- "!.github/workflows/docker-slim.yml"
- "!.github/workflows/lighthouse-badger.yml"
- "!.github/workflows/prettier.yml"
- "!lighthouse_results/**"
pull_request:
branches:
- master
- main
paths:
- "assets/**"
- "**.html"
- "**.js"
- "**.liquid"
- "**/*.md"
- "**.yml"
- "!.github/workflows/axe.yml"
- "!.github/workflows/deploy-docker-tag.yml"
- "!.github/workflows/deploy-image.yml"
- "!.github/workflows/docker-slim.yml"
- "!.github/workflows/lighthouse-badger.yml"
- "!.github/workflows/prettier.yml"
- "!lighthouse_results/**"

jobs:
link-checker:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4

- name: Link Checker 🔗
uses: lycheeverse/lychee-action@v1.9.0
Expand Down
Loading