Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Askstate updates #498

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Askstate updates #498

merged 4 commits into from
Nov 21, 2023

Conversation

doiron
Copy link
Contributor

@doiron doiron commented Nov 21, 2023

Issue #, if available:

Description of changes:

with this change the ask-state file preserves a bit more deployment metadata.

  • Last Import Id: The SMAPI import-id during the skill metadata was previously printed on the terminal, but if the terminal was closed it was impossible to fetch import status. By saving this to file you we can work on ask-cli features that would fetch previous imports status.
  • Skill Metadata Last Import Timestamp: A timestamp at which the last successful import took place.
  • Code Last Deploy Timestamp: A timestamp at which the last code endpoint successful deployment.
  • Deployment Status: shows if the ask-cli has an active deployment. it has two states: IN_PROGRESS | COMPLETE.

Other commits in this change:

  1. npm audit fix a few dependencies in package-lock.json file
  2. Hosted skill ask new workflow was broken due to invalid invocation name Hello World Skill. This was failing to build the model due to Upper casing and the word Skill in the name. Fixed by changing the Default Skill Name which is what the template was using to use as a Invocation name as well.
  3. updating the auto assign reviewers list to include CamdenFoucht and tydonelson only.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions github-actions bot requested a review from LucioMS November 21, 2023 20:57
@github-actions github-actions bot requested a review from tydonelson November 21, 2023 21:07
@doiron doiron merged commit 1e5eb69 into develop Nov 21, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants