Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch openssldir from env variable #162

Closed
wants to merge 1 commit into from
Closed

Fetch openssldir from env variable #162

wants to merge 1 commit into from

Conversation

h7x4
Copy link

@h7x4 h7x4 commented Oct 14, 2022

Resolves #161

@alexcrichton
Copy link
Owner

Instead of making this an env var can this be added as a configuration option on the builder?

@DanielSidhion
Copy link
Contributor

As far as I understand, adding this as a configuration option on the builder would imply that every crate that uses this one would need to properly configure it, is that correct? This will still require extra effort to fix every crate that depends on this, because when building with nix (as per #161) there will never be anything in /usr/local/ssl.

I don't know how many crates depend on this, but I think using the env var aligns with what the openssl crate does, which would fix the issue.

I'm struggling with this when trying to package a crate with vendored openssl with nix, and would like to help get this merged.

@alexcrichton
Copy link
Owner

AFAIK it's primarily openssl-sys, and maybe only openssl-sys, that depends on this crate. If the openssl crate has a convention for this environment variable then that's a good place to configure a builder-based option.

@DanielSidhion
Copy link
Contributor

It looks like there are a few other dependents, but the number is low enough that I agree a builder-based option is best. @h7x4 would you still like to work on this? I can create another PR to work on a builder-based option as well.

@alexcrichton
Copy link
Owner

Addressed in #220

@h7x4
Copy link
Author

h7x4 commented Dec 7, 2023

I'm sorry for being so unresponsive about this PR. Thank you for fixing it up @DanielSidhion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion to fetch openssldir from env variable
3 participants