Rust version compatibility fix #184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewwhitehead
force-pushed
the
fix/rust-compat
branch
from
f935d5b
to
d48c540
Compare
|
I'm not sure why the android builds are failing, unrelated? |
andrewwhitehead
force-pushed
the
fix/rust-compat
branch
from
d48c540
to
eafb6ee
Compare
|
You can comment out the android tests, the failures are unrelated. |
|
[&OsStr]::join which was not available (broken?) until Rust 1.63, To be compatible with versions before 1.63, join(OsStr:: new ("")) cannot be used, instead with fold(OsString::new(), |mut acc, v|{acc.push(v); acc.push(OsStr::new(" ")); acc}) |
This was referenced Jun 6, 2023
rbradford
added a commit
to rbradford/cloud-hypervisor
that referenced
this pull request
Jun 6, 2023
This is required for openssl-src crate as it now uses functionality first released in this version. See: alexcrichton/openssl-src-rs#184 Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
rbradford
added a commit
to cloud-hypervisor/cloud-hypervisor
that referenced
this pull request
Jun 6, 2023
This is required for openssl-src crate as it now uses functionality first released in this version. See: alexcrichton/openssl-src-rs#184 Signed-off-by: Rob Bradford <rbradford@rivosinc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that #180 is making use of
[&OsStr]::joinwhich was not available (broken?) until Rust 1.63: rust-lang/rust#96881Related: #181