Bump OpenSSL to 3.2.1 #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plus some fixes I needed to build this locally
amousset
approved these changes
Jan 30, 2024
link2xt
added a commit
to deltachat/deltachat-core-rust
that referenced
this pull request
Mar 3, 2024
Compilation of vendored OpenSSL inside Nix is broken since <alexcrichton/openssl-src-rs#229> due to build script changes. There is anyway no need to compile vendored OpenSSL as nixpkgs already contains OpenSSL package. This fixes `nix build .#deltachat-rpc-server-x86_64-linux` and similar commands which are used during releases.
link2xt
added a commit
to deltachat/deltachat-core-rust
that referenced
this pull request
Mar 4, 2024
Compilation of vendored OpenSSL inside Nix is broken since <alexcrichton/openssl-src-rs#229> due to build script changes. There is anyway no need to compile vendored OpenSSL as nixpkgs already contains OpenSSL package. This fixes `nix build .#deltachat-rpc-server-x86_64-linux` and similar commands which are used during releases.
link2xt
added a commit
to deltachat/deltachat-core-rust
that referenced
this pull request
Mar 4, 2024
Compilation of vendored OpenSSL inside Nix is broken since <alexcrichton/openssl-src-rs#229> due to build script changes. There is anyway no need to compile vendored OpenSSL as nixpkgs already contains OpenSSL package. This fixes `nix build .#deltachat-rpc-server-x86_64-linux` and similar commands which are used during releases.
link2xt
reviewed
Mar 4, 2024
| fs::create_dir_all(&dst).unwrap(); | ||
| cp_r(&path, &dst); | ||
| } else if ty.is_symlink() { |
There was a problem hiding this comment.
This change broke builds under Nix: #235
Builds fail with can't copy symlink "/nix/store/nqxnkxrqi9zx3zd60slbvg6pnyiprysv-crates-io-dependencies/openssl-src-300.2.3+3.2.1-5cff92b6f71555b61bb9315f7c64da3ca43d87531622120fea0195fc761b4843/openssl/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus some fixes I needed to build this locally