Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cc_env instead of path to set the CC configure variable #244

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

doy-materialize
Copy link
Contributor

this allows wrappers like sccache to work properly

@alexcrichton
Copy link
Owner

Thanks! This repository doesn't have a super high amount of traffic so the CI failures here may or may not be caused by this PR. This seems to me like it should work, but if you're ok with it pushing up a commit that reverts your change, just to see CI run against main as-is, will help diagnose if it's specific to this PR or not.

this allows wrappers like sccache to work properly
@doy-materialize
Copy link
Contributor Author

okay, this seems to work now.

@alexcrichton
Copy link
Owner

Thanks!

@alexcrichton alexcrichton merged commit 274732f into alexcrichton:main Jun 21, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants