Fix and improve backward sampling from data set and replay buffer #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vict0rsch
reviewed
Feb 8, 2024
vict0rsch
reviewed
Feb 8, 2024
vict0rsch
requested changes
Feb 8, 2024
vict0rsch
reviewed
Feb 9, 2024
|
No explicit approval from @vict0rsch but all comments have been addressed. In the interest of time, I will bypass protection and merge. |
|
Sorry, LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies the functionality to sample and construct a batch from a buffer (replay buffer or training data set) into a common Buffer method,
select().Tests
python -m pytest ./tests/