Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #277

Merged
merged 6 commits into from
Jan 31, 2024
Merged

Fix tests #277

merged 6 commits into from
Jan 31, 2024

Conversation

alexhernandezgarcia
Copy link
Owner

This PR fixes the issues with the tests that have showed up after the changes in PR #267

  • All tests are passed now.

josephdviviano
josephdviviano approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@josephdviviano josephdviviano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@josephdviviano josephdviviano merged commit cf0ec64 into jdv/test_fix Jan 31, 2024
1 check failed
@josephdviviano josephdviviano mentioned this pull request Jan 31, 2024
Closed
@josephdviviano josephdviviano deleted the fix-tests branch February 14, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephdviviano josephdviviano josephdviviano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexhernandezgarcia @josephdviviano