Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More system info #69

Merged
merged 1 commit into from
Apr 15, 2024
Merged

More system info #69

merged 1 commit into from
Apr 15, 2024

Conversation

Liborsaf
Copy link
Contributor

@Liborsaf Liborsaf commented Apr 5, 2024

No description provided.

@Liborsaf Liborsaf force-pushed the feature/system-info branch from 3dd9385 to a63a825 Compare April 7, 2024 10:58
@Liborsaf Liborsaf marked this pull request as ready for review April 7, 2024 20:32
@Liborsaf Liborsaf marked this pull request as draft April 7, 2024 20:39
@Liborsaf Liborsaf marked this pull request as ready for review April 7, 2024 20:48
@Liborsaf
Copy link
Contributor Author

Liborsaf commented Apr 8, 2024

Added those tests, hopefully they are somehow good 🤔

@Liborsaf Liborsaf marked this pull request as draft April 8, 2024 19:23
@Liborsaf
Copy link
Contributor Author

Liborsaf commented Apr 8, 2024

It seems that dmr contains even better system info, I have an idea, will try to implement one thing before merge.

@Liborsaf Liborsaf marked this pull request as ready for review April 8, 2024 20:33
@Liborsaf
Copy link
Contributor Author

Liborsaf commented Apr 8, 2024

In future I will try to make those tests (with dmr and only ircc) little better, but for now it seems to be ok and should work

@alexmohr
Copy link
Owner

alexmohr commented Apr 9, 2024

Please squash commits and then it's ready to be merged.

+ set_value helper
+ config file version tests
@Liborsaf Liborsaf force-pushed the feature/system-info branch from 9e06eff to 8a7fb4a Compare April 9, 2024 21:21
@alexmohr alexmohr merged commit dfba585 into alexmohr:master Apr 15, 2024
3 checks passed
@Liborsaf Liborsaf deleted the feature/system-info branch April 15, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants