Skip to content

Conversation

@kianmeng
Copy link

@kianmeng kianmeng commented Jan 3, 2022

Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Feature branch is up-to-date with main (if not - merge main into your branch).
  • Added tests.
  • Ran mix check.all, it verifies the formatting and runs credo and dialyzer
  • Ran mix test
  • Added an entry to the Changelog if the new code introduces user-observable changes. See the changelog entry format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant