Fix NameError if only 'railties' (not 'rails') gem is installed#58
Open
ojab wants to merge 1 commit intoalexrothenberg:mainfrom
Open
Fix NameError if only 'railties' (not 'rails') gem is installed#58ojab wants to merge 1 commit intoalexrothenberg:mainfrom
ojab wants to merge 1 commit intoalexrothenberg:mainfrom
Conversation
If a project depends on 'ammeter' and 'railties', `require 'ammeter/init'` fails with NameError: uninitialized constant ActionView::Template::Handlers::ERB::ENCODING_FLAG We need only 'rails/engine', so let's require it explicitly.
Author
|
…and I can't find any more or less proper way to fix the same in up-to-date |
|
I'm facing this same issue. I thought about forking this gem until this issue is fixed, but when I tried your fix @ojab , it didn't work for me. I get the same error from the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a project depends on 'ammeter' and 'railties',
require 'ammeter/init'fails withWe need only 'rails/engine', so let's require it explicitly.