Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #14: don’t require afterRender for views #15

Closed
wants to merge 1 commit into from

Conversation

djsegal
Copy link

@djsegal djsegal commented Apr 23, 2016

Edit:

Instead of building child link views afterRender, build them some time after render

@alexspeller
Copy link
Owner

Thanks for this, I need to spend some time checking this doesn't drastically impact performance for the non-wormhole case

@djsegal
Copy link
Author

djsegal commented Apr 26, 2016

@alexspeller let's table it till this weekend. I need a chance to look it over again

@alexspeller
Copy link
Owner

OK great, ping me when you do

@thesubr00t
Copy link

Hi @djsegal, Any updates?

@djsegal
Copy link
Author

djsegal commented Jul 8, 2016

@alexspeller I'm no longer running into any difficulties.

If @thesubr00t doesn't have any more concerns, I'm ok with closing both this PR and the issue

@djsegal
Copy link
Author

djsegal commented Jul 8, 2016

closing: pr didn't solve what it was addressing.


to clear my conscience, the following lines on master are a little odd and could probably be deleted:

@djsegal djsegal closed this Jul 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants