Fix ember 2.8+ #18
Merged
Fix ember 2.8+ #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robdel12
force-pushed
the
fix-ember-2.8
branch
from
3258783 to
88786f2
Compare
Robdel12
commented
Sep 14, 2016
| @@ -17,9 +17,11 @@ export default Ember.Mixin.create({ | |||
| Ember.run.schedule('afterRender', this, function(){ | |||
| let childLinkSelector = this.get('linkSelector'); | |||
| let childLinkElements = this.$(childLinkSelector); | |||
| let applicationContainer = Ember.getOwner(this).application.__container__; | |||
| let viewRegistry = applicationContainer.lookup('-view-registry:main') || Ember.View.views; | |||
There was a problem hiding this comment.
Curious if Ember.View.views is ever used.
|
@alexspeller this should be ready for your eyes |
Robdel12
force-pushed
the
fix-ember-2.8
branch
from
310e550 to
ffde375
Compare
When using `didRender` it caused an infinate render loop. Switching to `didReceiveAttrs` fixes the issue
|
👍 awesome, thanks for this. Making a new release now |
|
Version 0.3.0 has been published to npm, thanks again for your help! |
|
I've just updated to Ember 2.8 and v0.3 of this addon and I'm now seeing the following error in my tests: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the addon for Ember 2.8 and now works with Glimmer 2 also.
It's important to note that this will only support Ember 2.3+.