Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for disabled class. #2

Closed
wants to merge 1 commit into from

Conversation

lindyhopchris
Copy link

Hi Alex,

Hope you're well!

Finding this add-on really useful. However, it would be great to add support for adding a disabled class. I've added it but I'm not fussy about the implementation if you need to play around with it!

It's useful for some of the Bootstrap components, where you can add a disabled class to links as the opposite of active.

Cheers,
Chris

@lindyhopchris
Copy link
Author

Hi @alexspeller

Any chance this can be merged?

Cheers,
Chris

@alexspeller
Copy link
Owner

If you want this exact functionality, I would suggest subclassing the component instead and adding it in your subclass. Binding the disabled class from a child link to I'd want to proxy from the child itself but before adding that I'm waiting on #4

@lindyhopchris
Copy link
Author

Ah yes, that makes sense: would be good to get it from the child itself. I'll wait for #4 then update this pull request if you want.

@alexspeller alexspeller closed this Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants