Fastboot fixes #21
Merged
Fastboot fixes #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e no child link views
|
Looks great, thanks! |
|
Version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch
buildChildLinkViewsto usedidInsertElementsince it uses jQuery/ect (#19).Also adjusted the
allLinksDisabledCP since it returns a bit of a false positive in cases where the component contains no child link views (such as in fastboot, since the link views array is not built in this case), asisEvery()returns true if the array is empty. In fastboot apps, this causes the server rendered page to have the disabled class applied to all{{active-link}}s until the app boots on the client.