Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miniscript enroll #7

Merged
merged 1 commit into from
Nov 28, 2023

Conversation

edouardparis
Copy link
Contributor

@edouardparis edouardparis commented Nov 18, 2023

Hello, thank you very much for the library.

this PR adds two feature:

  • the new miniscript enroll that is used in Edge v6.2.1
  • A public exposure of some components to make it compatible with external Hidapi without taking ownership of it, example

@alfred-hodler
Copy link
Owner

Thank you for this improvement.

Could you please squash everything into a single commit, create a commit message in the style of previous commit messages and sign the commit? For example:

    Internal improvements
    
    * libsecp256k1 has been removed in favor of a native implementation (k256)
    
    * Improved device detection capabilities
    
    * CLI removes the remote connect feature

Furthermore, is there a summary of differences in HidApi between 2.4.1 and 1.3.3?

* Add miniscript enroll request

* Update hidapi dependency to 2.4.1

* Expose VID, PID and Coldcard::open method
@edouardparis
Copy link
Contributor Author

edouardparis commented Nov 28, 2023

Updated and signed the commit.

Here a summary of the differences between Hidapi 2.4.1 and 1.3.3.

The version increase of the library is to satisfy common dependency tree between multiple hardware wallet client libraries.

@alfred-hodler alfred-hodler merged commit 7654ed9 into alfred-hodler:master Nov 28, 2023
@alfred-hodler
Copy link
Owner

Merged and bumped semver to 0.9.0. Will publish on crates.io shortly. Thanks again.

@edouardparis
Copy link
Contributor Author

Thank you very much

@edouardparis edouardparis deleted the miniscript-enroll branch November 28, 2023 15:07
@alfred-hodler alfred-hodler mentioned this pull request Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants