fix: conform pagemap extension to sequence protocol #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
aallam
reviewed
Jul 26, 2024
Comment on lines
+86
to
+87
| let elements = (self.startIndex..<self.endIndex).map { self[$0] } | ||
| return IndexingIterator(_elements: elements) |
There was a problem hiding this comment.
I believe this creates a copy of the list elements, which should work. If performance issues arise, it might be wise to consider an alternative approach.
There was a problem hiding this comment.
Indeed, I see. I believe we can commit to it and monitor for customer feedback as you mentioned. Thanks for your review 🙇 !
aallam
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates a PageMap extension so that it conforms more closely to the Sequence protocol, which seems more restrictive with Xcode 16.
This also updates the CI to run tests on Xcode 16 and fixes a number of failing jobs.
Result
Fixes #318