Skip to content

Add replica indices to the secured api search key #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add replica indices to the secured api search key #316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/Repositories/ApiKeysRepository.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,11 +85,13 @@
// Key will be valid for 25 hours.
$validUntil = time() + (3600 * 25);

$replicas = config('scout-'.str_replace('_', '-', $searchableAs).'.replicas', []);
$restrictIndices = join(',', [$searchableAs, ...$replicas]);

Check warning on line 89 in src/Repositories/ApiKeysRepository.php

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

src/Repositories/ApiKeysRepository.php#L89 

Potential SQL injection with direct variable usage in join with param #3

$securedSearchKey = $this->client::generateSecuredApiKey($searchKey, [
'restrictIndices' => $searchableAs,
'restrictIndices' => $restrictIndices,
'validUntil' => $validUntil,
]);

$this->cache->put(
self::SEARCH_KEY.'.'.$searchableAs, $securedSearchKey, DateInterval::createFromDateString('24 hours')
);
Expand Down