Respect standard Scout Algolia config #326
Open
+25
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
This change ensures that standard Laravel Scout configuration for Algolia is respected when using Scout Extended.
What problem is this fixing?
Base Laravel Scout allows you to control certain features of the search client through configuration, but Scout extended ignores those configuratiton options.
This change makes scout extended respect the
connect_timeout,read_timeout,write_timeout, andbatch_sizeconfiguration options.I will note that base scout also doesn't currently pay attention to
batch_size, but that's the one setting that we wanted to change in the first place. I have opened a PR to scout to address this issue there, too.