Add syncing disabled for to aggregator #359
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qmeister
force-pushed
the
add-syncing-disabled-for-to-aggregator
branch
from
caeddb8 to
70a2399
Compare
qmeister
force-pushed
the
add-syncing-disabled-for-to-aggregator
branch
from
70a2399 to
c6ab9c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
syncingDisabledForfunctionality to theAggregatorObserverclass. Momentarily this is only implemented and used for aggregator models. But because this class inherits from theModelObserverthedisableSyncingForcould be potentially enabled for aggregator classes as well, for which this functionality is needed.What problem is this fixing?
If you set enable
syncingDisabledForfor an aggregator class it has no effect. This PR fixes this by implementing functionality so that aggregator classes also can havesyncingDisabledForenabled.