Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while, the github action for JS generation has been failing. Example: https://github.com/algorand/js-algorand-sdk/actions/runs/7241641297/job/19725977258
The problem was the logic to invoke the generator in
.github/actions/sdk-codegen/entrypoint.sh
became outdated and out of sync withscripts/generate_typescript.sh
, shown below:generator/scripts/generate_typescript.sh
Lines 80 to 95 in 88668a4
Additionally, I've updated the every languages' script to include the new step of cleaning directories before generation, which is currently present in their
scripts/generate_x.sh
files.Perhaps there's a smarter way to deduplicate this logic, but I just wanted to fix the problem for now.