Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug-fix: include currency-greater-than param for 0 value #584

Merged
merged 4 commits into from
Aug 10, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .test-env
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Configs for testing repo download:
SDK_TESTING_URL="https://github.com/algorand/algorand-sdk-testing"
SDK_TESTING_BRANCH="master"
SDK_TESTING_BRANCH="shiqi/pathupdates"
shiqizng marked this conversation as resolved.
Show resolved Hide resolved
SDK_TESTING_HARNESS="test-harness"

INSTALL_ONLY=0
Expand Down
4 changes: 2 additions & 2 deletions client/v2/indexer/lookupAccountTransactions.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ type LookupAccountTransactionsParams struct {
// CurrencyGreaterThan results should have an amount greater than this value.
// MicroAlgos are the default currency unless an asset-id is provided, in which
// case the asset will be used.
CurrencyGreaterThan uint64 `url:"currency-greater-than,omitempty"`
CurrencyGreaterThan *uint64 `url:"currency-greater-than,omitempty"`

// CurrencyLessThan results should have an amount less than this value. MicroAlgos
// are the default currency unless an asset-id is provided, in which case the asset
Expand Down Expand Up @@ -123,7 +123,7 @@ func (s *LookupAccountTransactions) BeforeTime(BeforeTime time.Time) *LookupAcco
// MicroAlgos are the default currency unless an asset-id is provided, in which
// case the asset will be used.
func (s *LookupAccountTransactions) CurrencyGreaterThan(CurrencyGreaterThan uint64) *LookupAccountTransactions {
s.p.CurrencyGreaterThan = CurrencyGreaterThan
s.p.CurrencyGreaterThan = &CurrencyGreaterThan

return s
}
Expand Down
4 changes: 2 additions & 2 deletions client/v2/indexer/lookupAssetBalances.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ type LookupAssetBalancesParams struct {
// CurrencyGreaterThan results should have an amount greater than this value.
// MicroAlgos are the default currency unless an asset-id is provided, in which
// case the asset will be used.
CurrencyGreaterThan uint64 `url:"currency-greater-than,omitempty"`
CurrencyGreaterThan *uint64 `url:"currency-greater-than,omitempty"`

// CurrencyLessThan results should have an amount less than this value. MicroAlgos
// are the default currency unless an asset-id is provided, in which case the asset
Expand Down Expand Up @@ -48,7 +48,7 @@ type LookupAssetBalances struct {
// MicroAlgos are the default currency unless an asset-id is provided, in which
// case the asset will be used.
func (s *LookupAssetBalances) CurrencyGreaterThan(CurrencyGreaterThan uint64) *LookupAssetBalances {
s.p.CurrencyGreaterThan = CurrencyGreaterThan
s.p.CurrencyGreaterThan = &CurrencyGreaterThan

return s
}
Expand Down
4 changes: 2 additions & 2 deletions client/v2/indexer/lookupAssetTransactions.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ type LookupAssetTransactionsParams struct {
// CurrencyGreaterThan results should have an amount greater than this value.
// MicroAlgos are the default currency unless an asset-id is provided, in which
// case the asset will be used.
CurrencyGreaterThan uint64 `url:"currency-greater-than,omitempty"`
CurrencyGreaterThan *uint64 `url:"currency-greater-than,omitempty"`

// CurrencyLessThan results should have an amount less than this value. MicroAlgos
// are the default currency unless an asset-id is provided, in which case the asset
Expand Down Expand Up @@ -142,7 +142,7 @@ func (s *LookupAssetTransactions) BeforeTime(BeforeTime time.Time) *LookupAssetT
// MicroAlgos are the default currency unless an asset-id is provided, in which
// case the asset will be used.
func (s *LookupAssetTransactions) CurrencyGreaterThan(CurrencyGreaterThan uint64) *LookupAssetTransactions {
s.p.CurrencyGreaterThan = CurrencyGreaterThan
s.p.CurrencyGreaterThan = &CurrencyGreaterThan

return s
}
Expand Down
4 changes: 2 additions & 2 deletions client/v2/indexer/searchForAccounts.go
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ type SearchAccountsParams struct {
// CurrencyGreaterThan results should have an amount greater than this value.
// MicroAlgos are the default currency unless an asset-id is provided, in which
// case the asset will be used.
CurrencyGreaterThan uint64 `url:"currency-greater-than,omitempty"`
CurrencyGreaterThan *uint64 `url:"currency-greater-than,omitempty"`

// CurrencyLessThan results should have an amount less than this value. MicroAlgos
// are the default currency unless an asset-id is provided, in which case the asset
Expand Down Expand Up @@ -88,7 +88,7 @@ func (s *SearchAccounts) AuthAddress(AuthAddress string) *SearchAccounts {
// MicroAlgos are the default currency unless an asset-id is provided, in which
// case the asset will be used.
func (s *SearchAccounts) CurrencyGreaterThan(CurrencyGreaterThan uint64) *SearchAccounts {
s.p.CurrencyGreaterThan = CurrencyGreaterThan
s.p.CurrencyGreaterThan = &CurrencyGreaterThan

return s
}
Expand Down
4 changes: 2 additions & 2 deletions client/v2/indexer/searchForTransactions.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ type SearchForTransactionsParams struct {
// CurrencyGreaterThan results should have an amount greater than this value.
// MicroAlgos are the default currency unless an asset-id is provided, in which
// case the asset will be used.
CurrencyGreaterThan uint64 `url:"currency-greater-than,omitempty"`
CurrencyGreaterThan *uint64 `url:"currency-greater-than,omitempty"`

// CurrencyLessThan results should have an amount less than this value. MicroAlgos
// are the default currency unless an asset-id is provided, in which case the asset
Expand Down Expand Up @@ -160,7 +160,7 @@ func (s *SearchForTransactions) BeforeTime(BeforeTime time.Time) *SearchForTrans
// MicroAlgos are the default currency unless an asset-id is provided, in which
// case the asset will be used.
func (s *SearchForTransactions) CurrencyGreaterThan(CurrencyGreaterThan uint64) *SearchForTransactions {
s.p.CurrencyGreaterThan = CurrencyGreaterThan
s.p.CurrencyGreaterThan = &CurrencyGreaterThan

return s
}
Expand Down
Loading