-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incentives: Add fields in block header for proposer and fees collected. #617
Conversation
e98bc28
to
347cc77
Compare
These are needed for algorand/go-algorand#5740 and should not be merged until that work is finalized.
347cc77
to
5ce1569
Compare
I'd expect this to also update |
Do we just keep them in perfect sync? Is the intent just to make everything available to callers? I can't think of any external functionality that would need access to the params, but I can see why we might have such an exposure policy. (We surely don't have it for any other sdk though) |
We only have it in this SDK for indexer & conduit to consume. There are a few consensus params that they check, such as whether rewards (the old style) are enabled, which influence their behavior/how they report certain things. The cross repo type check in algod also verifies that the consensus params are in sync. |
89392c1
to
8cc9f42
Compare
I think that's done - it's entirely manual, huh? There was more stuff in |
the block header is missing AbsentParticipationAccounts |
I thought it was a straight up copy-paste, but now I see the functions |
It was unclear to me how that model is used, but I figured I should copy the way expired accounts was done. |
…d. (algorand#617) * Add fields in block header for proposer and fees collected. * Add payouts related fields to Account * update consensus.go * Add absent participation accounts
…d. (algorand#617) * Add fields in block header for proposer and fees collected. * Add payouts related fields to Account * update consensus.go * Add absent participation accounts
* Fix: Fix indexer sync issue in cucumber tests (algorand#628) * Bump go version for builds/workflows to 1.20.14. (algorand#629) * Incentives: Add fields in block header for proposer and fees collected. (algorand#617) * Add fields in block header for proposer and fees collected. * Add payouts related fields to Account * update consensus.go * Add absent participation accounts * chore: fix function names (algorand#632) Signed-off-by: tianzedavid <cuitianze@aliyun.com> * Regenerate code from specification file (algorand#631) Co-authored-by: Algorand Generation Bot <codegen@algorand.com> * Fix funding for cucumber tests by rotating sender accounts (algorand#630) * Build: Bump golang version to 1.21.10 (algorand#636) * Bump golang version to 1.21.10 * Address new linter warnings. * bump up version to v2.5.0 * Regenerate code from specification file (algorand#635) Co-authored-by: Algorand Generation Bot <codegen@algorand.com> * Regenerate code from specification file (algorand#640) Co-authored-by: Algorand Generation Bot <codegen@algorand.com> * Regenerate code from specification file (algorand#641) Co-authored-by: Algorand Generation Bot <codegen@algorand.com> * Enable min-balance tests for indexer and algod APIs. (algorand#642) * bump up version to v2.6.0 * Update .test-env to use Cucumber specs from master (algorand#645) Update .test-env to use Cucumber specs from master rather than the now deprecated V2. * Bump gopkg.in/yaml.v3 from 3.0.0-20200313102051-9f266ea9e77c to 3.0.0 (algorand#605) Bumps gopkg.in/yaml.v3 from 3.0.0-20200313102051-9f266ea9e77c to 3.0.0. --- updated-dependencies: - dependency-name: gopkg.in/yaml.v3 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump golang.org/x/crypto (algorand#646) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.0.0-20210921155107-089bfa567519 to 0.17.0. - [Commits](https://github.com/golang/crypto/commits/v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Regenerate code from specification file (algorand#647) Co-authored-by: Algorand Generation Bot <codegen@algorand.com> --------- Signed-off-by: tianzedavid <cuitianze@aliyun.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jason Paulos <jasonpaulos@users.noreply.github.com> Co-authored-by: Gary <982483+gmalouf@users.noreply.github.com> Co-authored-by: John Jannotti <jannotti@gmail.com> Co-authored-by: tianzedavid <168427849+tianzedavid@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Algorand Generation Bot <codegen@algorand.com> Co-authored-by: gmalouf <gmalouf@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
These are needed for algorand/go-algorand#5740 and should not be merged until that work is finalized.