goal: non-interactive wallet creation with "wallet new --unencrypted --no-display-seed"

[tasosbit]

Adds this option to goal wallet new:

-n, --non-interactive
Create the new wallet without prompting for password or displaying the seed phrase

Skipping the password prompt is useful in scripted KMD creation.

The password prompt method for goal wallet new, which hides the input from the console, doesn't work with piping (unlike goal account import, which accepts echo apple apple apple ... | goal account import)

[jannotti]

I don't quite understand what this is doing, so I assume users will be in the same boat. Does it create a account that can be used without a password? Or with the empty password? Is there a distinction between those two things? Or perhaps it creates an account that kmd can't use, and the seed phrase must be used to recover it?

(a few minutes pass)

Having read some kmd source code, I think it makes an unencrypted wallet. I think the argument and the help text should be directed at telling the user that, rather than simply saying "skip password". Something like --unencrypted (and I would simply not have a short option, to make this less tempting for users who don't really want it.)

[codecov]

Codecov Report

Attention: Patch coverage is 14.28571% with 12 lines in your changes missing coverage. Please review.

Project coverage is 56.26%. Comparing base (eff5fb4) to head (f2c89e7).
Report is 81 commits behind head on master.

Files with missing lines	Patch %	Lines
cmd/goal/wallet.go	14.28%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #6160      +/-   ##
==========================================
- Coverage   56.29%   56.26%   -0.03%     
==========================================
  Files         494      494              
  Lines       69958    69964       +6     
==========================================
- Hits        39381    39366      -15     
- Misses      27907    27921      +14     
- Partials     2670     2677       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[tasosbit]

Having read some kmd source code, I think it makes an unencrypted wallet. I think the argument and the help text should be directed at telling the user that, rather than simply saying "skip password". Something like --unencrypted (and I would simply not have a short option, to make this less tempting for users who don't really want it.)

Correct, the idea is to create a wallet without prompting for password. I agree that unencrypted is a much better/clearer label than non-interactive. I will change this.

Will also split the unencrypted feature from the no-display-seed one

[algorandskiy]

Agree with JJ - use --unencrypted for suppressing the password prompt only. This should not affect the mnemonic output since a master key used for account key generation and orthogonal to wallet passwords.

[algorandskiy]

Removed shorthand options

[jannotti]

I suggested some UI wording changes, but otherwise happy to approve.

[algorandskiy]

Applied suggestions

[algorandskiy]

Fixed formatter