-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
catchpoints: add accountsRound check against R-320 horizon values to catchpointFileWriter #6240
Draft
cce
wants to merge
14
commits into
algorand:master
Choose a base branch
from
cce:fix-catchpoint-onlineaccts-horizon
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+307
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6240 +/- ##
=======================================
Coverage 51.76% 51.77%
=======================================
Files 644 644
Lines 86523 86533 +10
=======================================
+ Hits 44791 44803 +12
Misses 38864 38864
+ Partials 2868 2866 -2 ☔ View full report in Codecov by Sentry. |
…lineaccts-horizon
af3bdfb
to
ce9b32c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix issue with onlineaccounts updateRound column for certain accounts in catchpoint files when updateRound < R-320. Renames MakeOnlineAccountsIter to MakeOrderedOnlineAccountsIter (without logic changes) so it is more clear the DB provides an ordering on (account, updround).
Test Plan
Update tests and add new ones.