Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Block Header API Revamp #6248

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

gmalouf
Copy link
Contributor

@gmalouf gmalouf commented Feb 7, 2025

Summary

The recently added algod endpoint /v2/block/{round}/header has proved problematic for downstream SDK support. This PR:

  • Removes that new endpoint entirely (SDK support was not working as-is)
  • Adds a new parameter to /v2/block/{round} that allows a client to request the block header without either the certificate or the payset.

Test Plan

A new parameter test case was added to handlers_test.go.

…sactions and cert from response (algorand#6163)"

This reverts commit a6123b6.
@gmalouf gmalouf added the Bug-Fix label Feb 7, 2025
@gmalouf gmalouf self-assigned this Feb 7, 2025
@gmalouf gmalouf changed the title Revert "… API: Block Header API Revamp Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 51.77%. Comparing base (c490c22) to head (be04838).

Files with missing lines Patch % Lines
daemon/algod/api/server/v2/handlers.go 0.00% 19 Missing ⚠️
...ver/v2/generated/nonparticipating/public/routes.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6248   +/-   ##
=======================================
  Coverage   51.77%   51.77%           
=======================================
  Files         644      644           
  Lines       86523    86511   -12     
=======================================
- Hits        44793    44788    -5     
+ Misses      38863    38855    -8     
- Partials     2867     2868    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gmalouf gmalouf requested a review from algorandskiy February 10, 2025 19:32
@gmalouf gmalouf marked this pull request as ready for review February 10, 2025 19:34
@gmalouf gmalouf requested review from jannotti and cce February 10, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants