chore: update deprecated goreleaser option. #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1559 +/- ##
========================================
Coverage 68.58% 68.58%
========================================
Files 37 37
Lines 7417 7417
========================================
Hits 5087 5087
Misses 1903 1903
Partials 427 427 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Not at all. |
.goreleaser.yaml
Outdated
Comment on lines
98
to
100
| {{- else if eq .Arch "windows" }}Windows | ||
| {{- else if eq .Arch "linux" }}Linux | ||
| {{- else if eq .Arch "darwin" }}Darwin |
There was a problem hiding this comment.
It looks like based on the docs you linked you don't need overrides for these?
There was a problem hiding this comment.
You're right, these are not needed.
Eric-Warehime
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the deprecated replacements option according to recommendation in docs: https://goreleaser.com/deprecations/#archivesreplacements
I don't recall why the old template had a replacement for Arm. @Eric-Warehime do you know if it's needed?