CI: update CircleCI Ubuntu image to 24.04 #1633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ython. Otherwise we should vet newer PyYAML.
… newer Python. Otherwise we should vet newer PyYAML." This reverts commit 018c354.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1633 +/- ##
=======================================
Coverage 69.39% 69.39%
=======================================
Files 37 37
Lines 7375 7375
=======================================
Hits 5118 5118
Misses 1839 1839
Partials 418 418 ☔ View full report in Codecov by Sentry. |
gmalouf
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The previous image was deprecated and no longer works. This updates the image to the latest LTS (24.04) and a supported image.
Just bumping the Ubuntu version will break because the specified version of PyYAML (6.0) uses an incompatible version of cython. To fix this we just bump PyYAML, which fixed this in 6.0.2.
The CODEOWNERS file was also deprecated, so removing that as well.
Test Plan
CI Tests should pass.