-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incentives: Storing/ serving heartbeat transactions, synthetic transactions for payouts #1635
Conversation
…: this initial commit depends on a non-merged branch of go-algorand-sdk).
3b1b8fa
to
a1cc8af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only comments are about "heartbeat" being one word. I didn't mark them all up. Probably easier to grep for them.
…g set in block header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems ok now. But I suppose you will wait to get the new HeartbeatTxnFields in? Or do that separately?
I'm leaving as draft until your branch gets merged to master, will add the new fields once the crypto PR merges. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not like mixing payout fake transactions into regular ones but since it was decided - the code looks correct to me
Summary
Add support for storing and serving heartbeat transaction types. Generate a synthetic payout transaction (in underlying indexer txn table) to make inclusion of payouts in balances trackable by external users.
Test Plan
New tests were added for heartbeats as well as the synthetic payout.