Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incentives: Storing/ serving heartbeat transactions, synthetic transactions for payouts #1635

Merged
merged 8 commits into from
Dec 20, 2024

Conversation

gmalouf
Copy link
Contributor

@gmalouf gmalouf commented Nov 7, 2024

Summary

Add support for storing and serving heartbeat transaction types. Generate a synthetic payout transaction (in underlying indexer txn table) to make inclusion of payouts in balances trackable by external users.

Test Plan

New tests were added for heartbeats as well as the synthetic payout.

@gmalouf gmalouf added the Enhancement New feature or request label Nov 7, 2024
@gmalouf gmalouf self-assigned this Nov 7, 2024
@gmalouf gmalouf requested a review from jannotti November 7, 2024 19:52
@gmalouf gmalouf changed the title Add support for storing and serving heartbeat transaction types (note… Incentives: Add support for storing and serving heartbeat transaction types Nov 7, 2024
Copy link
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comments are about "heartbeat" being one word. I didn't mark them all up. Probably easier to grep for them.

api/converter_utils.go Outdated Show resolved Hide resolved
api/converter_utils.go Outdated Show resolved Hide resolved
api/generated/common/types.go Outdated Show resolved Hide resolved
api/indexer.oas2.json Outdated Show resolved Hide resolved
api/indexer.oas2.json Outdated Show resolved Hide resolved
api/indexer.oas2.json Outdated Show resolved Hide resolved
api/indexer.oas2.json Outdated Show resolved Hide resolved
api/indexer.oas2.json Outdated Show resolved Hide resolved
api/indexer.oas2.json Outdated Show resolved Hide resolved
@gmalouf gmalouf changed the title Incentives: Add support for storing and serving heartbeat transaction types Incentives: Storing/ serving heartbeat transactions, synthetic transactions for payouts Dec 6, 2024
Copy link
Contributor

@jannotti jannotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems ok now. But I suppose you will wait to get the new HeartbeatTxnFields in? Or do that separately?

@gmalouf
Copy link
Contributor Author

gmalouf commented Dec 11, 2024

It seems ok now. But I suppose you will wait to get the new HeartbeatTxnFields in? Or do that separately?

I'm leaving as draft until your branch gets merged to master, will add the new fields once the crypto PR merges.

api/converter_utils.go Show resolved Hide resolved
@gmalouf gmalouf marked this pull request as ready for review December 20, 2024 19:48
Copy link
Contributor

@algorandskiy algorandskiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not like mixing payout fake transactions into regular ones but since it was decided - the code looks correct to me

@gmalouf gmalouf merged commit c5c7b4e into algorand:main Dec 20, 2024
5 checks passed
@gmalouf gmalouf deleted the heartbeat-support branch December 20, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants