Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dynamic tuple encoding with boolean values #577

Merged
merged 11 commits into from
Dec 18, 2024
Merged

Conversation

joe-p
Copy link
Contributor

@joe-p joe-p commented Dec 17, 2024

No description provided.

error: stack underflow in box_put. at:68. Error during resource population simulation in transaction 0: transaction SH6U2CA7VLLXW3Z3WNIAJ4ISEDGQW255ES62AVCRT6BNOEWFTTEA: logic eval error: stack underflow in box_put. Details: app=1003, pc=133, opcodes=pop; concat; box_put
Copy link

netlify bot commented Dec 17, 2024

Deploy Preview for tealscript ready!

Name Link
🔨 Latest commit ecf168a
🔍 Latest deploy log https://app.netlify.com/sites/tealscript/deploys/67632bdf8ccf9c0008744eb7
😎 Deploy Preview https://deploy-preview-577--tealscript.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Expected: [ 1n, 2n, 3n, false, [ "abcd", "efgh" ] ]
Received: undefined
First problem of extra concat is solved, but now the problem is that the head offset is off by one byte (0x0024 with bool, 0x0025 with uint8). I think the problem is that the initial head offset is calculated before processing the boolean values, resulting in them not being accounted for in the offset.
@joe-p joe-p force-pushed the fix/nested_array_in_box branch from 06a8d07 to 3c51654 Compare December 17, 2024 22:02
@joe-p joe-p changed the title fix: nested array in box fix: dynamic tuple encoding with boolean values Dec 18, 2024
@joe-p joe-p marked this pull request as ready for review December 18, 2024 21:11
@joe-p joe-p merged commit 19d9482 into dev Dec 18, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant