use network:app:appID:pubKey for subject #195

Sign in to view logs

Triggered via pull request May 2, 2024 20:45

joe-p

synchronize #106

network_in_did

Status Failure

Total duration 1m 55s

Artifacts –

ci.yml

on: pull_request

scan for vulnerabilities

validate protobuf definitions

Matrix: code quality and correctness

Annotations

23 errors and 9 warnings

code quality and correctness (1.20.x, ubuntu-latest): client/ui/provider.go#L267

Error return value of `w.Write` is not checked (errcheck)

code quality and correctness (1.20.x, ubuntu-latest): client/ui/api_test.go#L73

Consider pre-allocating `accts` (prealloc)

code quality and correctness (1.20.x, ubuntu-latest): client/ui/api_test.go#L171

response body must be closed (bodyclose)

code quality and correctness (1.20.x, ubuntu-latest): client/ui/api_test.go#L177

response body must be closed (bodyclose)

code quality and correctness (1.20.x, ubuntu-latest): client/ui/api_test.go#L188

response body must be closed (bodyclose)

code quality and correctness (1.20.x, ubuntu-latest): client/ui/api_test.go#L44

non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)

code quality and correctness (1.20.x, ubuntu-latest): client/ui/api_test.go#L49

non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)

code quality and correctness (1.20.x, ubuntu-latest): client/ui/api_test.go#L65

non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)

code quality and correctness (1.20.x, ubuntu-latest): client/ui/api_test.go#L98

ineffectual assignment to err (ineffassign)

code quality and correctness (1.20.x, ubuntu-latest): client/ui/api_test.go#L119

ineffectual assignment to err (ineffassign)

code quality and correctness (1.19.x, ubuntu-latest)

The job was canceled because "_1_20_x_ubuntu-latest" failed.

code quality and correctness (1.19.x, ubuntu-latest): client/ui/provider.go#L267

Error return value of `w.Write` is not checked (errcheck)

code quality and correctness (1.19.x, ubuntu-latest): client/ui/api_test.go#L73

Consider pre-allocating `accts` (prealloc)

code quality and correctness (1.19.x, ubuntu-latest): client/ui/api_test.go#L171

response body must be closed (bodyclose)

code quality and correctness (1.19.x, ubuntu-latest): client/ui/api_test.go#L177

response body must be closed (bodyclose)

code quality and correctness (1.19.x, ubuntu-latest): client/ui/api_test.go#L188

response body must be closed (bodyclose)

code quality and correctness (1.19.x, ubuntu-latest): client/ui/api_test.go#L44

non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)

code quality and correctness (1.19.x, ubuntu-latest): client/ui/api_test.go#L49

non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)

code quality and correctness (1.19.x, ubuntu-latest): client/ui/api_test.go#L65

non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)

code quality and correctness (1.19.x, ubuntu-latest): client/ui/api_test.go#L98

ineffectual assignment to err (ineffassign)

code quality and correctness (1.19.x, ubuntu-latest): client/ui/api_test.go#L119

ineffectual assignment to err (ineffassign)

code quality and correctness (1.21.x, ubuntu-latest)

The job was canceled because "_1_20_x_ubuntu-latest" failed.

code quality and correctness (1.21.x, ubuntu-latest)

The operation was canceled.

scan for vulnerabilities

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@v4. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

validate protobuf definitions

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@v4, bufbuild/buf-setup-action@v1.29.0, bufbuild/buf-lint-action@v1.0.3, bufbuild/buf-breaking-action@v1.1.2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

code quality and correctness (1.20.x, ubuntu-latest)

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@v4, golangci/golangci-lint-action@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

code quality and correctness (1.20.x, ubuntu-latest): client/internal/contracts.go#L53

exported: exported function LoadContract should have comment or be unexported (revive)

code quality and correctness (1.20.x, ubuntu-latest): client/ui/api_test.go#L52

var-naming: var walletId should be walletID (revive)

code quality and correctness (1.20.x, ubuntu-latest): client/ui/api_test.go#L252

var-naming: var createdAppId should be createdAppID (revive)

code quality and correctness (1.19.x, ubuntu-latest): client/internal/contracts.go#L53

exported: exported function LoadContract should have comment or be unexported (revive)

code quality and correctness (1.19.x, ubuntu-latest): client/ui/api_test.go#L52

var-naming: var walletId should be walletID (revive)

code quality and correctness (1.19.x, ubuntu-latest): client/ui/api_test.go#L252

var-naming: var createdAppId should be createdAppID (revive)