Feat/separate views in txn modal #121
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactor: view transitions
…nge duration error message
# Conflicts: # internal/accounts_test.go # ui/controls/view.go # ui/error.go # ui/error_test.go # ui/modals/exception/error_test.go # ui/modals/generate/style.go # ui/pages/accounts/accounts_test.go # ui/pages/generate/controller.go # ui/pages/generate/view.go # ui/pages/transaction/view.go # ui/style/style.go
test(node): basic playbook and coverage strategy
…ility feat: incentive eligibility check for automated fees
…key-detection chore: improve active key detection
fix: add update for brew
…-update-prompt-for-dev-versions chore: disable nodekit upgrade nag for dev versions
…encoding Fix: participation key rendering from base64url to base64
…-eligibility-fees feat: enable incentive eligibility fees
…eporting fix: improve command error handling
…onally # Conflicts: # cmd/bootstrap.go # cmd/root.go
…-fast-catchup-conditionally chore: skip questions when already bootstrapped
…stats feat: add disk space information to debug command
Docs: Changed doc link on landing page to redirect to new dev portal
Deploying nodekit-run with
|
| Latest commit: |
3e4c917
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0c57119d.nodekit-run.pages.dev |
| Branch Preview URL: | https://feat-separate-views-in-txn-m.nodekit-run.pages.dev |
tasosbit
force-pushed
the
feat/separate-views-in-txn-modal
branch
from
503c6e6 to
d259aae
Compare
…nstable-node fix: wait for status from unstable clients
|
Looks like the history is off here, we may want to reapply the changes in this case |
tasosbit
force-pushed
the
feat/separate-views-in-txn-modal
branch
from
3e4c917 to
6ada694
Compare
tasosbit
force-pushed
the
feat/separate-views-in-txn-modal
branch
from
6ada694 to
4d66d1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ Overview
The transaction modal was very noisy/busy with both QR and link instructions.
Splitting transaction modal into two modes, one for link and one for QR.
TODO: Controls label does not currently update
📝 Related Issues
✅ Acceptance: