Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: view transitions #24

Merged
merged 60 commits into from
Nov 28, 2024
Merged

refactor: view transitions #24

merged 60 commits into from
Nov 28, 2024

Conversation

PhearZero
Copy link
Member

@PhearZero PhearZero commented Nov 5, 2024 •
edited
Loading

ℹ Overview

  • refactors navigation
  • allows modal placement
  • allows colors with adornments

Screenshot from 2024-11-12 12-24-18
Screenshot from 2024-11-12 12-23-56
Screenshot from 2024-11-12 12-23-39
Screenshot from 2024-11-12 12-23-33
Screenshot from 2024-11-12 12-23-26

📝 Related Issues

✅ Acceptance:

  • Pre-commit checks pass

@PhearZero PhearZero added this to the Milestone 1 milestone Nov 5, 2024
@PhearZero PhearZero self-assigned this Nov 5, 2024
@PhearZero PhearZero changed the title Refactor/view transitions refactor: view transitions Nov 5, 2024
@PhearZero PhearZero mentioned this pull request Nov 5, 2024
Closed
1 task
@PhearZero PhearZero force-pushed the refactor/view-transitions branch from c78efe4 to c4aeb72 Compare November 6, 2024 19:50
@PhearZero PhearZero force-pushed the refactor/view-transitions branch from 0d7558f to 3fa81c6 Compare November 6, 2024 20:25
@PhearZero PhearZero marked this pull request as ready for review November 6, 2024 20:29
@PhearZero PhearZero force-pushed the refactor/view-transitions branch from 3fa81c6 to cf08e02 Compare November 6, 2024 20:32
@PhearZero PhearZero force-pushed the refactor/view-transitions branch from cf08e02 to d78a619 Compare November 6, 2024 20:46
@PhearZero PhearZero force-pushed the refactor/view-transitions branch from 3ef50da to b5cb153 Compare November 12, 2024 12:37
@tasosbit
Copy link
Contributor

Can we try these changes in the delete key confirmation modal:

  • move Account Address up, over part key id
  • add newlines between the sections
Are you sure...

Account address:
ABC

Participation Key ID:
XYZ

@codecov Codecov
Copy link

codecov bot commented Nov 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.97752% with 152 lines in your changes missing coverage. Please review.

Project coverage is 70.79%. Comparing base (587e75a) to head (58d3e8d).
Report is 62 commits behind head on main.

Files with missing lines Patch % Lines
ui/viewport.go 55.69% 33 Missing and 2 partials ⚠️
internal/test/utils.go 52.94% 19 Missing and 5 partials ⚠️
ui/modal/controller.go 80.32% 24 Missing ⚠️
internal/test/client.go 90.73% 17 Missing and 2 partials ⚠️
ui/style/style.go 77.14% 11 Missing and 5 partials ⚠️
internal/participation.go 84.48% 8 Missing and 1 partial ⚠️
internal/state.go 57.89% 6 Missing and 2 partials ⚠️
internal/accounts.go 75.00% 5 Missing and 1 partial ⚠️
cmd/status.go 0.00% 3 Missing ⚠️
internal/status.go 72.72% 1 Missing and 2 partials ⚠️
... and 2 more
Additional details and impacted files 
@@             Coverage Diff             @@
##             main      #24       +/-   ##
===========================================
+ Coverage   51.61%   70.79%   +19.18%     
===========================================
  Files          37       44        +7     
  Lines        3094     3736      +642     
===========================================
+ Hits         1597     2645     +1048     
+ Misses       1324      925      -399     
+ Partials      173      166        -7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PhearZero PhearZero force-pushed the refactor/view-transitions branch from b54dbf3 to 3baeb62 Compare November 19, 2024 17:07
@PhearZero
Merge branch 'main' into refactor/view-transitions
e71253c 
# Conflicts:
#	go.mod
#	ui/controls/controls_test.go
tasosbit
tasosbit reviewed Nov 26, 2024
View reviewed changes
internal/participation.go Outdated Show resolved Hide resolved
tasosbit
tasosbit reviewed Nov 26, 2024
View reviewed changes
cmd/root.go Outdated Show resolved Hide resolved
tasosbit
tasosbit reviewed Nov 26, 2024
View reviewed changes
internal/accounts.go Outdated Show resolved Hide resolved
@PhearZero PhearZero force-pushed the refactor/view-transitions branch from c93494c to d0ad886 Compare November 27, 2024 19:11
@PhearZero PhearZero force-pushed the refactor/view-transitions branch from d0ad886 to 58d3e8d Compare November 27, 2024 19:12
tasosbit
tasosbit approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@tasosbit tasosbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LATM

@PhearZero PhearZero merged commit ee1c17f into main Nov 28, 2024
3 checks passed
@PhearZero PhearZero deleted the refactor/view-transitions branch November 28, 2024 14:20
tasosbit pushed a commit that referenced this pull request Jan 22, 2025
@HashMapsData2Value
# This is a combination of 39 commits.
143f477 
# This is the 1st commit message:

feat: add prompt-ui

# This is the commit message #2:

feat: configure and set algod data directory

# This is the commit message #3:

fix: RX/TX display

# This is the commit message #4:

fix: bit rate display for GB

# This is the commit message #5:

fix: configuration override order

# This is the commit message #6:

feat: handle invalid configuration and token gracefully

# This is the commit message #7:

test: fix test state

# This is the commit message #8:

fix: loading of custom endpoint address

# This is the commit message #9:

fix: loading default port

# This is the commit message #10:

test: clear viper settings

# This is the commit message #11:

fix: finds path to directory and gives cmd instruction

# This is the commit message #12:

feat: adds node start and node stop commands

# This is the commit message #13:

fix: add -y

# This is the commit message #14:

fix: turn script into indivudal commands

# This is the commit message #15:

feat: check if sudo, clarify shell

# This is the commit message #16:

chore: make more go idiomatic

# This is the commit message #17:

fix: fix proper path check

# This is the commit message #18:

fix: interact with systemctl, cleanup prompts

# This is the commit message #19:

fix: remove sudo

# This is the commit message #20:

fix: separate commands

# This is the commit message #21:

fix: proper algorand service name

# This is the commit message #22:

fix: calling with sudo

# This is the commit message #23:

chore: testing systemctl

# This is the commit message #24:

fix: checks algorand system service has been enabled directly

# This is the commit message #25:

feat: implements editAlgorandServiceFile

# This is the commit message #26:

fix: else statement

# This is the commit message #27:

fix: quick check branch

# This is the commit message #28:

fix: string template

# This is the commit message #29:

feat: adds upgrade

# This is the commit message #30:

chore: removeu nnecessary code

# This is the commit message #31:

fix: check that installed and candidate are the same

# This is the commit message #32:

chore: improve print

# This is the commit message #33:

chore: add more output

# This is the commit message #34:

fix: single quote

# This is the commit message #35:

fix: -y

# This is the commit message #36:

fix: systemctl

# This is the commit message #37:

fix: upgrade and sudo text

# This is the commit message #38:

chore: go mod tidy

# This is the commit message #39:

fix: upgrade
tasosbit pushed a commit that referenced this pull request Jan 22, 2025
@HashMapsData2Value
# This is a combination of 46 commits.
8b95cd4 
# This is the 1st commit message:

feat: add prompt-ui

# This is the commit message #2:

feat: configure and set algod data directory

# This is the commit message #3:

fix: RX/TX display

# This is the commit message #4:

fix: bit rate display for GB

# This is the commit message #5:

fix: configuration override order

# This is the commit message #6:

feat: handle invalid configuration and token gracefully

# This is the commit message #7:

test: fix test state

# This is the commit message #8:

fix: loading of custom endpoint address

# This is the commit message #9:

fix: loading default port

# This is the commit message #10:

test: clear viper settings

# This is the commit message #11:

fix: finds path to directory and gives cmd instruction

# This is the commit message #12:

feat: adds node start and node stop commands

# This is the commit message #13:

fix: add -y

# This is the commit message #14:

fix: turn script into indivudal commands

# This is the commit message #15:

feat: check if sudo, clarify shell

# This is the commit message #16:

chore: make more go idiomatic

# This is the commit message #17:

fix: fix proper path check

# This is the commit message #18:

fix: interact with systemctl, cleanup prompts

# This is the commit message #19:

fix: remove sudo

# This is the commit message #20:

fix: separate commands

# This is the commit message #21:

fix: proper algorand service name

# This is the commit message #22:

fix: calling with sudo

# This is the commit message #23:

chore: testing systemctl

# This is the commit message #24:

fix: checks algorand system service has been enabled directly

# This is the commit message #25:

feat: implements editAlgorandServiceFile

# This is the commit message #26:

fix: else statement

# This is the commit message #27:

fix: quick check branch

# This is the commit message #28:

fix: string template

# This is the commit message #29:

feat: adds upgrade

# This is the commit message #30:

chore: removeu nnecessary code

# This is the commit message #31:

fix: check that installed and candidate are the same

# This is the commit message #32:

chore: improve print

# This is the commit message #33:

chore: add more output

# This is the commit message #34:

fix: single quote

# This is the commit message #35:

fix: -y

# This is the commit message #36:

fix: systemctl

# This is the commit message #37:

fix: upgrade and sudo text

# This is the commit message #38:

chore: go mod tidy

# This is the commit message #39:

fix: upgrade

# This is the commit message #40:

feat: disable ui elements while syncing

# This is the commit message #41:

feat: skip account loading on syncing
feat: remove offline account expires date

# This is the commit message #42:

feat: installs algod and sets up service on mac

# This is the commit message #43:

feat: refactor, + mac

# This is the commit message #44:

feat: adds uninstall, mac only

# This is the commit message #45:

fix: remove plist file

# This is the commit message #46:

chore: rename
tasosbit pushed a commit that referenced this pull request Jan 22, 2025
@HashMapsData2Value
# This is a combination of 51 commits.
0a3eac0 
# This is the 1st commit message:

feat: add prompt-ui

# This is the commit message #2:

feat: configure and set algod data directory

# This is the commit message #3:

fix: RX/TX display

# This is the commit message #4:

fix: bit rate display for GB

# This is the commit message #5:

fix: configuration override order

# This is the commit message #6:

feat: handle invalid configuration and token gracefully

# This is the commit message #7:

test: fix test state

# This is the commit message #8:

fix: loading of custom endpoint address

# This is the commit message #9:

fix: loading default port

# This is the commit message #10:

test: clear viper settings

# This is the commit message #11:

fix: finds path to directory and gives cmd instruction

# This is the commit message #12:

feat: adds node start and node stop commands

# This is the commit message #13:

fix: add -y

# This is the commit message #14:

fix: turn script into indivudal commands

# This is the commit message #15:

feat: check if sudo, clarify shell

# This is the commit message #16:

chore: make more go idiomatic

# This is the commit message #17:

fix: fix proper path check

# This is the commit message #18:

fix: interact with systemctl, cleanup prompts

# This is the commit message #19:

fix: remove sudo

# This is the commit message #20:

fix: separate commands

# This is the commit message #21:

fix: proper algorand service name

# This is the commit message #22:

fix: calling with sudo

# This is the commit message #23:

chore: testing systemctl

# This is the commit message #24:

fix: checks algorand system service has been enabled directly

# This is the commit message #25:

feat: implements editAlgorandServiceFile

# This is the commit message #26:

fix: else statement

# This is the commit message #27:

fix: quick check branch

# This is the commit message #28:

fix: string template

# This is the commit message #29:

feat: adds upgrade

# This is the commit message #30:

chore: removeu nnecessary code

# This is the commit message #31:

fix: check that installed and candidate are the same

# This is the commit message #32:

chore: improve print

# This is the commit message #33:

chore: add more output

# This is the commit message #34:

fix: single quote

# This is the commit message #35:

fix: -y

# This is the commit message #36:

fix: systemctl

# This is the commit message #37:

fix: upgrade and sudo text

# This is the commit message #38:

chore: go mod tidy

# This is the commit message #39:

fix: upgrade

# This is the commit message #40:

feat: disable ui elements while syncing

# This is the commit message #41:

feat: skip account loading on syncing
feat: remove offline account expires date

# This is the commit message #42:

feat: installs algod and sets up service on mac

# This is the commit message #43:

feat: refactor, + mac

# This is the commit message #44:

feat: adds uninstall, mac only

# This is the commit message #45:

fix: remove plist file

# This is the commit message #46:

chore: rename

# This is the commit message #47:

test: protocol snapshots and 100%

# This is the commit message #48:

test: status snapshots and 100%

# This is the commit message #49:

test: error page snapshots and 100%

# This is the commit message #50:

test: controls snapshots

# This is the commit message #51:

test: accounts snapshots
tasosbit pushed a commit that referenced this pull request Jan 22, 2025
@PhearZero
Merge pull request #24 from algorandfoundation/refactor/view-transitions
8549b25 
refactor: view transitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasosbit tasosbit tasosbit approved these changes

Assignees

@PhearZero PhearZero

Labels
refactor
Projects
None yet
Milestone
Milestone 1
Development

Successfully merging this pull request may close these issues.
2 participants
@PhearZero @tasosbit