-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Node Install, Start, Stop, Upgrade ENG-572 #25
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25 +/- ##
===========================================
- Coverage 68.70% 56.06% -12.65%
===========================================
Files 44 60 +16
Lines 3934 5012 +1078
===========================================
+ Hits 2703 2810 +107
- Misses 1078 2019 +941
- Partials 153 183 +30 ☔ View full report in Codecov by Sentry. |
# This is the 1st commit message: feat: add prompt-ui # This is the commit message #2: feat: configure and set algod data directory # This is the commit message #3: fix: RX/TX display # This is the commit message #4: fix: bit rate display for GB # This is the commit message #5: fix: configuration override order # This is the commit message #6: feat: handle invalid configuration and token gracefully # This is the commit message #7: test: fix test state # This is the commit message #8: fix: loading of custom endpoint address # This is the commit message #9: fix: loading default port # This is the commit message #10: test: clear viper settings # This is the commit message #11: fix: finds path to directory and gives cmd instruction # This is the commit message #12: feat: adds node start and node stop commands # This is the commit message #13: fix: add -y # This is the commit message #14: fix: turn script into indivudal commands # This is the commit message #15: feat: check if sudo, clarify shell # This is the commit message #16: chore: make more go idiomatic # This is the commit message #17: fix: fix proper path check # This is the commit message #18: fix: interact with systemctl, cleanup prompts # This is the commit message #19: fix: remove sudo # This is the commit message #20: fix: separate commands # This is the commit message #21: fix: proper algorand service name # This is the commit message #22: fix: calling with sudo # This is the commit message #23: chore: testing systemctl # This is the commit message #24: fix: checks algorand system service has been enabled directly # This is the commit message #25: feat: implements editAlgorandServiceFile # This is the commit message #26: fix: else statement # This is the commit message #27: fix: quick check branch # This is the commit message #28: fix: string template # This is the commit message #29: feat: adds upgrade # This is the commit message #30: chore: removeu nnecessary code # This is the commit message #31: fix: check that installed and candidate are the same # This is the commit message #32: chore: improve print # This is the commit message #33: chore: add more output # This is the commit message #34: fix: single quote # This is the commit message #35: fix: -y # This is the commit message #36: fix: systemctl # This is the commit message #37: fix: upgrade and sudo text # This is the commit message #38: chore: go mod tidy # This is the commit message #39: fix: upgrade
# This is the 1st commit message: feat: add prompt-ui # This is the commit message #2: feat: configure and set algod data directory # This is the commit message #3: fix: RX/TX display # This is the commit message #4: fix: bit rate display for GB # This is the commit message #5: fix: configuration override order # This is the commit message #6: feat: handle invalid configuration and token gracefully # This is the commit message #7: test: fix test state # This is the commit message #8: fix: loading of custom endpoint address # This is the commit message #9: fix: loading default port # This is the commit message #10: test: clear viper settings # This is the commit message #11: fix: finds path to directory and gives cmd instruction # This is the commit message #12: feat: adds node start and node stop commands # This is the commit message #13: fix: add -y # This is the commit message #14: fix: turn script into indivudal commands # This is the commit message #15: feat: check if sudo, clarify shell # This is the commit message #16: chore: make more go idiomatic # This is the commit message #17: fix: fix proper path check # This is the commit message #18: fix: interact with systemctl, cleanup prompts # This is the commit message #19: fix: remove sudo # This is the commit message #20: fix: separate commands # This is the commit message #21: fix: proper algorand service name # This is the commit message #22: fix: calling with sudo # This is the commit message #23: chore: testing systemctl # This is the commit message #24: fix: checks algorand system service has been enabled directly # This is the commit message #25: feat: implements editAlgorandServiceFile # This is the commit message #26: fix: else statement # This is the commit message #27: fix: quick check branch # This is the commit message #28: fix: string template # This is the commit message #29: feat: adds upgrade # This is the commit message #30: chore: removeu nnecessary code # This is the commit message #31: fix: check that installed and candidate are the same # This is the commit message #32: chore: improve print # This is the commit message #33: chore: add more output # This is the commit message #34: fix: single quote # This is the commit message #35: fix: -y # This is the commit message #36: fix: systemctl # This is the commit message #37: fix: upgrade and sudo text # This is the commit message #38: chore: go mod tidy # This is the commit message #39: fix: upgrade # This is the commit message #40: feat: disable ui elements while syncing # This is the commit message #41: feat: skip account loading on syncing feat: remove offline account expires date # This is the commit message #42: feat: installs algod and sets up service on mac # This is the commit message #43: feat: refactor, + mac # This is the commit message #44: feat: adds uninstall, mac only # This is the commit message #45: fix: remove plist file # This is the commit message #46: chore: rename
feat: configure and set algod data directory fix: RX/TX display fix: bit rate display for GB fix: configuration override order feat: handle invalid configuration and token gracefully test: fix test state fix: loading of custom endpoint address fix: loading default port test: clear viper settings fix: finds path to directory and gives cmd instruction feat: adds node start and node stop commands fix: add -y fix: turn script into indivudal commands feat: check if sudo, clarify shell chore: make more go idiomatic fix: fix proper path check fix: interact with systemctl, cleanup prompts fix: remove sudo fix: separate commands fix: proper algorand service name fix: calling with sudo chore: testing systemctl fix: checks algorand system service has been enabled directly feat: implements editAlgorandServiceFile fix: else statement fix: quick check branch fix: string template feat: adds upgrade chore: removeu nnecessary code fix: check that installed and candidate are the same chore: improve print chore: add more output fix: single quote fix: -y fix: systemctl fix: upgrade and sudo text chore: go mod tidy fix: upgrade feat: disable ui elements while syncing feat: skip account loading on syncing feat: remove offline account expires date feat: installs algod and sets up service on mac feat: refactor, + mac feat: adds uninstall, mac only fix: remove plist file chore: rename test: protocol snapshots and 100%
# This is the 1st commit message: feat: add prompt-ui # This is the commit message #2: feat: configure and set algod data directory # This is the commit message #3: fix: RX/TX display # This is the commit message #4: fix: bit rate display for GB # This is the commit message #5: fix: configuration override order # This is the commit message #6: feat: handle invalid configuration and token gracefully # This is the commit message #7: test: fix test state # This is the commit message #8: fix: loading of custom endpoint address # This is the commit message #9: fix: loading default port # This is the commit message #10: test: clear viper settings # This is the commit message #11: fix: finds path to directory and gives cmd instruction # This is the commit message #12: feat: adds node start and node stop commands # This is the commit message #13: fix: add -y # This is the commit message #14: fix: turn script into indivudal commands # This is the commit message #15: feat: check if sudo, clarify shell # This is the commit message #16: chore: make more go idiomatic # This is the commit message #17: fix: fix proper path check # This is the commit message #18: fix: interact with systemctl, cleanup prompts # This is the commit message #19: fix: remove sudo # This is the commit message #20: fix: separate commands # This is the commit message #21: fix: proper algorand service name # This is the commit message #22: fix: calling with sudo # This is the commit message #23: chore: testing systemctl # This is the commit message #24: fix: checks algorand system service has been enabled directly # This is the commit message #25: feat: implements editAlgorandServiceFile # This is the commit message #26: fix: else statement # This is the commit message #27: fix: quick check branch # This is the commit message #28: fix: string template # This is the commit message #29: feat: adds upgrade # This is the commit message #30: chore: removeu nnecessary code # This is the commit message #31: fix: check that installed and candidate are the same # This is the commit message #32: chore: improve print # This is the commit message #33: chore: add more output # This is the commit message #34: fix: single quote # This is the commit message #35: fix: -y # This is the commit message #36: fix: systemctl # This is the commit message #37: fix: upgrade and sudo text # This is the commit message #38: chore: go mod tidy # This is the commit message #39: fix: upgrade # This is the commit message #40: feat: disable ui elements while syncing # This is the commit message #41: feat: skip account loading on syncing feat: remove offline account expires date # This is the commit message #42: feat: installs algod and sets up service on mac # This is the commit message #43: feat: refactor, + mac # This is the commit message #44: feat: adds uninstall, mac only # This is the commit message #45: fix: remove plist file # This is the commit message #46: chore: rename # This is the commit message #47: test: protocol snapshots and 100% # This is the commit message #48: test: status snapshots and 100% # This is the commit message #49: test: error page snapshots and 100% # This is the commit message #50: test: controls snapshots # This is the commit message #51: test: accounts snapshots
feat: configure and set algod data directory fix: RX/TX display fix: bit rate display for GB fix: configuration override order feat: handle invalid configuration and token gracefully test: fix test state fix: loading of custom endpoint address fix: loading default port test: clear viper settings fix: finds path to directory and gives cmd instruction feat: adds node start and node stop commands fix: add -y fix: turn script into indivudal commands feat: check if sudo, clarify shell chore: make more go idiomatic fix: fix proper path check fix: interact with systemctl, cleanup prompts fix: remove sudo fix: separate commands fix: proper algorand service name fix: calling with sudo chore: testing systemctl fix: checks algorand system service has been enabled directly feat: implements editAlgorandServiceFile fix: else statement fix: quick check branch fix: string template feat: adds upgrade chore: removeu nnecessary code fix: check that installed and candidate are the same chore: improve print chore: add more output fix: single quote fix: -y fix: systemctl fix: upgrade and sudo text chore: go mod tidy fix: upgrade feat: disable ui elements while syncing feat: skip account loading on syncing feat: remove offline account expires date feat: installs algod and sets up service on mac feat: refactor, + mac feat: adds uninstall, mac only fix: remove plist file chore: rename test: protocol snapshots and 100% test: status snapshots and 100% test: error page snapshots and 100% test: controls snapshots test: accounts snapshots build: go mod tidy README: Add alpha/dev warnings & notes README: Moved note README: added note README: added note about admin token README: reordered README: numbered build steps README: final note test: add codecov reporter ci: temp node test flow chore: only when push systemctl ENABLE fix: rm -f file fix: install start and uninstall for redhat fix: add systemctl check chore: printout fix: ubuntu-based uninstall fix: uninstallation remove service fix: adds extar systemctl daemon-reload chroe: temp fix: provide output chore: dont fail silently fix: wildcard fix: remove extra daemon-reload fix: remore unnecessary output chore: rephrase ci: run in pushes
e3fbfbe
to
85f7966
Compare
chore: return msg.quit chore: fix imports chore: adjust imports chore: space chore: fix space chore: fix status chore: fix merge error chore: return docs
9c07882
to
0ffecc5
Compare
# Conflicts: # internal/accounts_test.go # ui/controls/view.go # ui/error.go # ui/error_test.go # ui/modals/exception/error_test.go # ui/modals/generate/style.go # ui/pages/accounts/accounts_test.go # ui/pages/generate/controller.go # ui/pages/generate/view.go # ui/pages/transaction/view.go # ui/style/style.go
test(node): basic playbook and coverage strategy
# Conflicts: # .gitignore # cmd/root.go # cmd/root_test.go # cmd/status.go # internal/block.go # internal/block_test.go # internal/metrics.go # internal/state_test.go # ui/pages/accounts/model.go # ui/protocol.go # ui/protocol_test.go # ui/status.go # ui/status_test.go
c7586ac
to
8414f71
Compare
1a30346
to
74e75ae
Compare
74e75ae
to
5561b8c
Compare
One more comment - I realize it might not be strictly within the confines of this PR, but I do think that if a user has used ./algorun-tui to do a node install, and given that the node debug command shows the location of the data directory, I do believe that the user should be able to do ./algorun-tui without any endpoint or token flag and have the command figure out on its own to grab the token and try the default http://localhost:8080 endpoint . On the off-chance that there is a separate algod running on that endpoint the token will fail to authenticate and we will know what's wrong. If there's no algod at all then the tui can complain, or perhaps use some other mechanism to search through the user's ports and find the correct one. From a UX perspective I think even for me (who contributed to this PR) it is cumbersome to have to type out |
This is poor naming on the command, it is very limited in scope and relates to the next comment
I'll try to think of a way to clean it up or name it appropriately. I want to provide an interface for writing the plist file for power users. I was using it heavily at first and decided to dogfood it with the installer.
I have a pretty good idea on how to bring enough of the configuration command over without biting off too much. |
# This is the 1st commit message: feat: add prompt-ui # This is the commit message #2: feat: configure and set algod data directory # This is the commit message #3: fix: RX/TX display # This is the commit message #4: fix: bit rate display for GB # This is the commit message #5: fix: configuration override order # This is the commit message #6: feat: handle invalid configuration and token gracefully # This is the commit message #7: test: fix test state # This is the commit message #8: fix: loading of custom endpoint address # This is the commit message #9: fix: loading default port # This is the commit message #10: test: clear viper settings # This is the commit message #11: fix: finds path to directory and gives cmd instruction # This is the commit message #12: feat: adds node start and node stop commands # This is the commit message #13: fix: add -y # This is the commit message #14: fix: turn script into indivudal commands # This is the commit message #15: feat: check if sudo, clarify shell # This is the commit message #16: chore: make more go idiomatic # This is the commit message #17: fix: fix proper path check # This is the commit message #18: fix: interact with systemctl, cleanup prompts # This is the commit message #19: fix: remove sudo # This is the commit message #20: fix: separate commands # This is the commit message #21: fix: proper algorand service name # This is the commit message #22: fix: calling with sudo # This is the commit message #23: chore: testing systemctl # This is the commit message #24: fix: checks algorand system service has been enabled directly # This is the commit message #25: feat: implements editAlgorandServiceFile # This is the commit message #26: fix: else statement # This is the commit message #27: fix: quick check branch # This is the commit message #28: fix: string template # This is the commit message #29: feat: adds upgrade # This is the commit message #30: chore: removeu nnecessary code # This is the commit message #31: fix: check that installed and candidate are the same # This is the commit message #32: chore: improve print # This is the commit message #33: chore: add more output # This is the commit message #34: fix: single quote # This is the commit message #35: fix: -y # This is the commit message #36: fix: systemctl # This is the commit message #37: fix: upgrade and sudo text # This is the commit message #38: chore: go mod tidy # This is the commit message #39: fix: upgrade
# This is the 1st commit message: feat: add prompt-ui # This is the commit message #2: feat: configure and set algod data directory # This is the commit message #3: fix: RX/TX display # This is the commit message #4: fix: bit rate display for GB # This is the commit message #5: fix: configuration override order # This is the commit message #6: feat: handle invalid configuration and token gracefully # This is the commit message #7: test: fix test state # This is the commit message #8: fix: loading of custom endpoint address # This is the commit message #9: fix: loading default port # This is the commit message #10: test: clear viper settings # This is the commit message #11: fix: finds path to directory and gives cmd instruction # This is the commit message #12: feat: adds node start and node stop commands # This is the commit message #13: fix: add -y # This is the commit message #14: fix: turn script into indivudal commands # This is the commit message #15: feat: check if sudo, clarify shell # This is the commit message #16: chore: make more go idiomatic # This is the commit message #17: fix: fix proper path check # This is the commit message #18: fix: interact with systemctl, cleanup prompts # This is the commit message #19: fix: remove sudo # This is the commit message #20: fix: separate commands # This is the commit message #21: fix: proper algorand service name # This is the commit message #22: fix: calling with sudo # This is the commit message #23: chore: testing systemctl # This is the commit message #24: fix: checks algorand system service has been enabled directly # This is the commit message #25: feat: implements editAlgorandServiceFile # This is the commit message #26: fix: else statement # This is the commit message #27: fix: quick check branch # This is the commit message #28: fix: string template # This is the commit message #29: feat: adds upgrade # This is the commit message #30: chore: removeu nnecessary code # This is the commit message #31: fix: check that installed and candidate are the same # This is the commit message #32: chore: improve print # This is the commit message #33: chore: add more output # This is the commit message #34: fix: single quote # This is the commit message #35: fix: -y # This is the commit message #36: fix: systemctl # This is the commit message #37: fix: upgrade and sudo text # This is the commit message #38: chore: go mod tidy # This is the commit message #39: fix: upgrade # This is the commit message #40: feat: disable ui elements while syncing # This is the commit message #41: feat: skip account loading on syncing feat: remove offline account expires date # This is the commit message #42: feat: installs algod and sets up service on mac # This is the commit message #43: feat: refactor, + mac # This is the commit message #44: feat: adds uninstall, mac only # This is the commit message #45: fix: remove plist file # This is the commit message #46: chore: rename
# This is the 1st commit message: feat: add prompt-ui # This is the commit message #2: feat: configure and set algod data directory # This is the commit message #3: fix: RX/TX display # This is the commit message #4: fix: bit rate display for GB # This is the commit message #5: fix: configuration override order # This is the commit message #6: feat: handle invalid configuration and token gracefully # This is the commit message #7: test: fix test state # This is the commit message #8: fix: loading of custom endpoint address # This is the commit message #9: fix: loading default port # This is the commit message #10: test: clear viper settings # This is the commit message #11: fix: finds path to directory and gives cmd instruction # This is the commit message #12: feat: adds node start and node stop commands # This is the commit message #13: fix: add -y # This is the commit message #14: fix: turn script into indivudal commands # This is the commit message #15: feat: check if sudo, clarify shell # This is the commit message #16: chore: make more go idiomatic # This is the commit message #17: fix: fix proper path check # This is the commit message #18: fix: interact with systemctl, cleanup prompts # This is the commit message #19: fix: remove sudo # This is the commit message #20: fix: separate commands # This is the commit message #21: fix: proper algorand service name # This is the commit message #22: fix: calling with sudo # This is the commit message #23: chore: testing systemctl # This is the commit message #24: fix: checks algorand system service has been enabled directly # This is the commit message #25: feat: implements editAlgorandServiceFile # This is the commit message #26: fix: else statement # This is the commit message #27: fix: quick check branch # This is the commit message #28: fix: string template # This is the commit message #29: feat: adds upgrade # This is the commit message #30: chore: removeu nnecessary code # This is the commit message #31: fix: check that installed and candidate are the same # This is the commit message #32: chore: improve print # This is the commit message #33: chore: add more output # This is the commit message #34: fix: single quote # This is the commit message #35: fix: -y # This is the commit message #36: fix: systemctl # This is the commit message #37: fix: upgrade and sudo text # This is the commit message #38: chore: go mod tidy # This is the commit message #39: fix: upgrade # This is the commit message #40: feat: disable ui elements while syncing # This is the commit message #41: feat: skip account loading on syncing feat: remove offline account expires date # This is the commit message #42: feat: installs algod and sets up service on mac # This is the commit message #43: feat: refactor, + mac # This is the commit message #44: feat: adds uninstall, mac only # This is the commit message #45: fix: remove plist file # This is the commit message #46: chore: rename # This is the commit message #47: test: protocol snapshots and 100% # This is the commit message #48: test: status snapshots and 100% # This is the commit message #49: test: error page snapshots and 100% # This is the commit message #50: test: controls snapshots # This is the commit message #51: test: accounts snapshots
feat: Node Install, Start, Stop, Upgrade ENG-572
ℹ Overview
📝 Related Issues
✅ Acceptance: