Fix: install.sh to test for curl, otherwise use wget #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhearZero
approved these changes
Jan 15, 2025
PhearZero
force-pushed
the
fix/install-sh-wget-alternative
branch
from
f9e912a to
27dcf54
Compare
Deploying nodekit-run with
|
| Latest commit: |
27dcf54
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://919d6c36.nodekit-run.pages.dev |
| Branch Preview URL: | https://fix-install-sh-wget-alternat.nodekit-run.pages.dev |
tasosbit
pushed a commit
that referenced
this pull request
Jan 22, 2025
…ternative chore: install.sh to test for curl, otherwise use wget
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ Overview
We offer wget as an install command, but install.sh was still using curl internally. Fixed it to fall back to wget if curl is not available
✅ Acceptance: