feat: migrate simple, kitchen-sink, calculator examples from tealscript to puya-ts #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boblat
force-pushed
the
feat/calculator-example
branch
3 times, most recently
from
f949227 to
a2b1741
Compare
- *also*: refactor: rearrange folders
boblat
force-pushed
the
feat/calculator-example
branch
from
932b873 to
03b2e29
Compare
boblat
changed the title
joe-p
reviewed
Mar 7, 2025
| import type { uint64 } from "@algorandfoundation/algorand-typescript"; | ||
|
|
||
| // eslint-disable-next-line no-unused-vars | ||
| export class Calculator extends arc4.Contract { |
There was a problem hiding this comment.
I think it'd be good if we tried to reduce the usage of arc4 as much as possible (ie. just use Contract instead of arc4.Contract). TEALScript has no explicit mention of ARC4/ABI anywhere in the API and obviously ARC4 is new to TypeScript developers. The more code we can write without having to use it the better and finding areas where it's required is during the migration process is a good way to figure out what needs to be worked on
There was a problem hiding this comment.
It has been updated to use just Contract.
boblat
force-pushed
the
feat/calculator-example
branch
3 times, most recently
from
6e926a0 to
31e2cd5
Compare
boblat
force-pushed
the
feat/calculator-example
branch
2 times, most recently
from
c0672d6 to
c2c652d
Compare
boblat
force-pushed
the
feat/calculator-example
branch
from
c2c652d to
5eb777f
Compare
|
One thing I noticed is that there's a lot of noise in the diffs due to formatting which makes migration look more burdensome than it is. For example:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.