Adding "arc" as a hash prefix for ARC messages #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARC (https://github.com/algorandfoundation/ARCs) sometimes requires hashing of some messages. This change is to ensure that `arcXXXX` is reserved for that purpose. This change is already in the go-algorand code: https://github.com/algorand/go-algorand/blob/2bc55c06f4dacf247b93a15f47530f57b4925d28/protocol/hash.go#L28
|
I don't know that this needs to be in the algorand spec, proper. These hashes always appear above L1, don't they? |
|
It's mostly to be sure there is no collision of prefix between L1 and above levels. |
nullun
approved these changes
May 28, 2025
cusma
approved these changes
May 28, 2025
There was a problem hiding this comment.
@fabrice102 I think reserving the arc keyword in the specs to avoid its usage at L1 is justified, as the related ARC standards have reached a stable and mature state in the ecosystem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARC (https://github.com/algorandfoundation/ARCs) sometimes requires hashing of some messages. This change is to ensure that
arcXXXXis reserved for that purpose. This change is already in the go-algorand code:https://github.com/algorand/go-algorand/blob/2bc55c06f4dacf247b93a15f47530f57b4925d28/protocol/hash.go#L28