fix(interactive): Add error handling for expression parsing and support get global id for edge #4228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g edge element id(global_id) Committed-by: xiaolei.zl from Dev container
zhanglei1949
commented
Sep 12, 2024
| } else if (pt.has_label()) { | ||
| getter_ = create_edge_label_path_accessor(ctx, tag); | ||
| var.getter_ = create_edge_label_path_accessor(ctx, tag); | ||
| } else if (pt.has_id()) { |
There was a problem hiding this comment.
Support getting edge global id.
|
Please check the preview of the documentation changes at |
longbinlai
approved these changes
Sep 13, 2024
|
This PR need to be reviewed, since introducing error handling for expression could be expressive. We will fix the problem first via this PR: #4230 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4226