fix: Path concatenation issue for authentication requests in Envoy authentication mode #1709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thentication mode
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1709 +/- ##
==========================================
+ Coverage 35.91% 43.63% +7.72%
==========================================
Files 69 76 +7
Lines 11576 12358 +782
==========================================
+ Hits 4157 5393 +1236
+ Misses 7104 6628 -476
- Partials 315 337 +22 |
johnlanni
requested changes
Jan 23, 2025
…thentication mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
The original request URL is encoded, which causes issues with the concatenation of the authentication request path in Envoy authentication mode.
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
原始请求：
认证服务获取的请求参数：
Ⅴ. Special notes for reviews