-
Notifications
You must be signed in to change notification settings - Fork 780
feat(ai-proxy): support Google Cloud Vertex #2119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2119 +/- ##
===========================================
+ Coverage 35.91% 46.06% +10.15%
===========================================
Files 69 81 +12
Lines 11576 13010 +1434
===========================================
+ Hits 4157 5993 +1836
+ Misses 7104 6671 -433
- Partials 315 346 +31 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我改了一点格式问题,麻烦pull一下。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
还有两个地方希望能够完善一下:
- 更新 README.md,添加 Google Vertex 的配置说明
- 等到 TTL 完全到了再刷新 token 可能会因计时偏差导致部分请求使用到过期 token。建议加一个提前量,可以允许用户配置,默认可以 1分钟
| `vertexRegion` | string | 必填 | - | Google Cloud 区域(如 us-central1, europe-west4 等),用于构建 Vertex API 地址 | | ||
| `vertexProjectId` | string | 必填 | - | Google Cloud 项目 ID,用于标识目标 GCP 项目 | | ||
| `vertexAuthServiceName` | string | 必填 | - | 用于 OAuth2 认证的服务名称,该服务为了访问oauth2.googleapis.com | | ||
| `vertexGeminiSafetySetting` | map of string | 非必填 | - | Gemini 模型的内容安全过滤设置。 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没看到新加的那个 ahead 。。。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Kent Dong <ch3cho@qq.com>
Hi @HecarimV , 请教下,这个 Hi @HecarimV, please tell me how to configure the |
Ⅰ. Describe what this PR did
support
Google Cloud Vertex
providerⅡ. Does this pull request fix one issue?
fix: #1697
Ⅳ. Describe how to verify it
docker-compose.yaml
envoy.yaml
测试非流式请求:
测试流式请求:
Ⅴ. Special notes for reviews
vertex api 文档:https://cloud.google.com/vertex-ai/generative-ai/docs/model-reference/inference