feat: add e2e unittest framework #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #251 +/- ##
==========================================
+ Coverage 32.02% 32.30% +0.28%
==========================================
Files 41 41
Lines 6426 6426
==========================================
+ Hits 2058 2076 +18
+ Misses 4079 4060 -19
- Partials 289 290 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
dongjiang1989
force-pushed
the
e2e-framework
branch
from
f9fa90e
to
cfd9647
Compare
|
@peter-wangxu PTAL |
|
Do you plan adding a example test case other than install CRD? |
Yes. I will continue to add e2e cases. |
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
|
@peter-wangxu It's need to update token? |
Signed-off-by: dongjiang1989 <dongjiang1989@126.com>
|
Did you pass local testing? If yes i am ok to merge this now. |
dongjiang1989
commented
Jan 16, 2024
Comment on lines
+28
to
+73
| func testInsertAgent(ctx context.Context) func(t *testing.T) { | ||
| return func(t *testing.T) { | ||
| testCtx := testframework.NewTestCtx(t) | ||
| defer testCtx.Cleanup(t) | ||
|
|
||
| testNS := testframework.CreateNamespace(context.Background(), t, testCtx) | ||
|
|
||
| err := testframework.CreateOrUpdateDaemonSetAndWaitUntilReady(context.Background(), testNS, &appsv1.DaemonSet{ | ||
| TypeMeta: metav1.TypeMeta{ | ||
| Kind: "DaemonSet", | ||
| APIVersion: "apps/v1", | ||
| }, | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "test-agent", | ||
| Namespace: testNS, | ||
| Annotations: map[string]string{}, | ||
| }, | ||
| Spec: appsv1.DaemonSetSpec{ | ||
| Selector: &metav1.LabelSelector{ | ||
| MatchLabels: map[string]string{ | ||
| "name": "test-agent", | ||
| }, | ||
| }, | ||
| Template: corev1.PodTemplateSpec{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Labels: map[string]string{ | ||
| "name": "test-agent", | ||
| }, | ||
| }, | ||
| Spec: corev1.PodSpec{ | ||
| Containers: []corev1.Container{ | ||
| { | ||
| Name: "agent", | ||
| Image: testframework.Image, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }) | ||
|
|
||
| if err != nil { | ||
| t.Fatal(err) | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
@peter-wangxu this is example e2e case.
Yes. Please merge it. I will continue to add e2e cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add e2e unittest framework and add One case for CRD Install
fix #248